In the vein of theming the IPE controller: #887444

Since the IPE controller is ubiquitous on panel pages, we had some other functionality that fit the concept of the controller. So we are adding other links to the controller, we needed the javascript to handle the case where there are more buttons to hide/show.

This patch is an attempt to generalize this, 'hide all things in the ipe-off class'/'show all things with ipe-on'. This is a pretty specific need but I think the javascript can be generalized without hurting the general use case.

CommentFileSizeAuthor
#1 panels_ipe-888410.patch1.08 KBjonskulski

Comments

jonskulski’s picture

jonskulski commented
Status: Active » Needs review
StatusFileSize
new panels_ipe-888410.patch1.08 KB

Here is a patch to review

We generalize the javascript here.

Also, I wasn't sure what the position: absolute calls in javascript were doing. They didn't seem to be needed in any of my browsers tests and were placing links ontop of each other. We'll need to figure that piece out if it was necessary.

Similarly, I got rid of the max-width part since it didn't seem to be needed and is quickly unnecessary with any kind of extra buttons

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

Patch no longer applies due to other work in the same area.

Letharion’s picture

Letharion commented
Status: Needs work » Closed (won't fix)

Closing this issue as it's been in "Needs work" for over 6 months. Feel free to re-open if you re-roll the patch.