Closed (fixed)
Project:
Quant
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Aug 2010 at 22:10 UTC
Updated:
27 Aug 2010 at 22:17 UTC
I've found that t() function wasn't used properly in quant.chart.in and quant.forms.inc. There should be no variables, constants etc inside its brackets. It was neccessary to remove them as suggested here. So I created two patches for quant.chart.in and quant.forms.inc and attached them to this issue.
| Comment | File | Size | Author |
|---|---|---|---|
| quant_forms_t.patch | 496 bytes | Ingumsky | |
| quant_chart_t.patch | 1.93 KB | Ingumsky |
Comments
Comment #1
mstef commentedGood catch good catch...when I'm coding at top speed, I always skip over a few t()'s by accident.
Comment #2
Ingumsky commentedContent is always much more important than form -)
Comment #3
mstef commentedPretty sure a t shouldn't even be used here at all..
The labels should be overridden when they're originally declared.
Comment #4
mstef commentedhttp://drupal.org/cvs?commit=413120
Please revise your .pot and .po file and I'll bring them into the module.
Comment #5
mstef commentedComment #6
Ingumsky commentedIt's been already done :) .pot and .po files were extracted from patched version of the module.
Comment #7
mstef commentedCan you just check again? I didn't use the patches - I did them manually.
Thanks
Comment #8
Ingumsky commentedYep, I checked and they were okay. Anyway I decided to re-extract them and update Russian translation. Hopefully it's even better now. Both files were uploaded again in their respective threads.