drupal_alter() for $node_diffs

Keen to add this, but there is no line #340 in current dev

@realityloop
I'm going to push through a number of minor patches that should go in before the big patch. This will make it easier to backport these to Drupal 6 and provide better tracking.

Looking forward, the Drupal 7 patch introduces the diff.api.php file that hints at the upcoming changes and warns users that hook_diff() is depreciated. The actual alter is:

+  // Allow other modules to interact directly with the results.
+  $context = array(
+    'old_entity' => $old_node,
+    'new_entity' => $new_node,
+    'entity_type' => 'node',
+  );
+  drupal_alter('entity_diff', $node_diffs, $context);

And Drupal 6 is just:

+  // Allow other modules to interact directly with the results.
+  drupal_alter('node_diffs', $node_diffs, $old_node, $new_node, $remove_markup);

I wish I had a dollar for every time that I save before attaching the patches :)

To give commit credit (and thus someone to blame if things go wrong) the following format can be used:

D7
git commit --author="aland <aland@198838.no-reply.drupal.org>" -m="Issue 888680 by Deciphered, Alan D.: Allow modules to interact via drupal_alter()"

D6
git commit --author="deciphered <deciphered@103796.no-reply.drupal.org>" -m="Issue 888680 by Deciphered, Alan D.: Allow modules to interact via drupal_alter()"

Usage
Apply patch
git add -A
The commit
(repeat for other patches on branch)
Push

The author gets the commit authorship once pushed but I'm not sure what the other user roles get. My policy is to push through individual commits accrediting the code writer, and note users that have interacted in a significant way in the commit - aka users that reported the bug, testers, reviewers, etc. Though sometimes I do use "John Doe, et al:" if there are many.

No-one seems to use format-patch :(

Anyway, it is a nice way of tracking users through the system and I think that if more maintainers use this, it should spark more interest in non-maintainers to actually write patches

Core is different, it never happens.

http://drupal.org/node/38878/committers is a great example why to

Cool, I may have to get you to get your project manager to free some time contrib time for Brain to push some things through :)

Fixing tags

This should be resolved with the new branch, 7.x-3.0-alpha1 or 7.x-3.0-dev.

Actually, this can be backported if I find the time :)

This is fixed in 7.x-3.x. Backport requests should be made in separate issues, if absolutely necessary.