I'm using CTools 1.7, Panels 3.7, Views 2.11, Tabs 1.3, and Tabs Panel Style 1.0-rc4 (but I've tired with the latest -dev as well)
I have a page that consists of one region. The region is called "Center" and has style set to tabs (non-filling). It has several views that are all calendars. I also have a couple of other pages with two regions - one on top for some text, and a set of tabs for the main content (views with pagers).
I originally noticed this with the normal views, but it directly affects the calendars since there's no way to enable AJAX on them.
It appears the code in panels_tabs.js does not update the links for the pager with the tabs (and, in my slightly modified version, for the calendar). Specifically, around line 22 of panels_tabs.js we have the following code:
for (var id in Drupal.settings.panelsTabs) {
var $tabs = $('#tabs-'+ id +' > ul > li');
I put in an alert there to look at the id being returned, which is being returned as "-center". Yet there is no div with an id of "tabs--center" (or "tabs-center"). There are divs with an id of "tabs-tabset", but this is not referenced in that code.
The result of this is that the jquery code does not update the links to set the tab references, and thus any click that returns to the same page (i.e. pagers, calendars) always returns to the first tab.
Any thoughts on how to fix this?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | panels_tabs_set_tabset_id.patch | 1.67 KB | 13rac1 |
Comments
Comment #2
13rac1 commentedThe tabs.inc file is not specifying the names of the tabsets correctly. Perhaps something changed in the Tabs module?
The attached patch fixes the
This patch will not fix calendars, the JS needs to be modified to support them. Patch to support Calendars: #896998: Add support for Calendar Views within Panel tabs.
Comment #3
smoothify commentedesorei: Thanks for you work on this patch and your other work in the issue queue.
As the maintainer of the module, I will review all active issues later this week. (I have got house guests at the moment).
Thanks
Ben
Comment #4
smoothify commentedThis worked great for me, now committed.
Thank you :)
Comment #5
smoothify commentedchanging status..
Comment #7
savedario commentedI am changing the status because it seems to me this patch has not been included in the latest rc5 version.
Is this patch still needed ?
I applied it on rc5 and it does solve the problem...
Thanks
Comment #8
smoothify commentedsavedario: thanks for reporting this, it does seem that the patch didn't make it into the last release (RC5) despite being committed.
I have now rolled another release - RC6, hopefully this time it solves the problem!