Followup from #880820: Add 'Maintain issues' checkbox to the project maintainers form ...

It'd be nice to have some tests for the new "Maintain issues" checkbox on the project maintainers tab. We've already got them for the perms provided by project and project_release, which are more serious. But, it'd be good to confirm via simpletest that the issue maintainer perm works as expected.

CommentFileSizeAuthor
#8 889744-project-issue-maintainer-tests-8.patch5.51 KBmikey_p
#7 889744-project-issue-maintainer-tests-6.patch4.69 KBmikey_p
#6 889744-6.maintain-issues-bug.patch1 KBdww
#4 drupal.org files issues 889744-project-issue-maintainer-tests-2.patch.txt4.69 KBdrumm
#2 889744-project-issue-maintainer-tests-2.patch4.69 KBmikey_p

Comments

mikey_p’s picture

mikey_p commented
Issue tags: +drupal.org redesign sprint 3
mikey_p’s picture

mikey_p commented
Assigned: Unassigned » mikey_p
Status: Active » Needs work
StatusFileSize
new 889744-project-issue-maintainer-tests-2.patch4.69 KB

I can't get these passing locally and can't seem to get the maintainers feature working properly at all even though it seems to be working fine on d.o. I'm not sure if there is still an odd reliance on CVSlog or something that is affecting this, but it may be worth checking into. Here's to hoping the test bot can pick up on this.

mikey_p’s picture

mikey_p commented
Status: Needs work » Needs review

Setting to needs review to see what the test bot thinks...

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new drupal.org files issues 889744-project-issue-maintainer-tests-2.patch.txt4.69 KB

Re-uploading the same patch to see if it triggers a test. I don't think status changes are retroactive.

drumm’s picture

drumm
he/him
Location NY, US
commented

Actually automated testing is not enabled for this project at http://drupal.org/node/75232/edit/issues. I don't know if there are any special requirements, so I won't turn it on myself.

dww’s picture

dww
we/he/they
commented
StatusFileSize
new 889744-6.maintain-issues-bug.patch1 KB

Argh, that's because the feature is actually broken. ;) See attached patch.

mikey_p’s picture

mikey_p commented
Status: Needs review » Needs work
StatusFileSize
new 889744-project-issue-maintainer-tests-6.patch4.69 KB

Stashing this here while I reroll with the patch from #6.

mikey_p’s picture

mikey_p commented
StatusFileSize
new 889744-project-issue-maintainer-tests-8.patch5.51 KB

153 passes, 0 fails, and 0 exceptions ;)

I still need to review this to see if we need any more tests or if this is complete.

dww’s picture

dww
we/he/they
commented
Status: Needs work » Fixed

Reviewed the tests, look good. Ran the tests without the issue.inc patch from #6. 2 fails. Applied my fix from #6 and all tests pass. Also manually tested a bit to verify. Committed to HEAD. I'll comment here when this is live on d.o.

dww’s picture

dww
we/he/they
commented

This is now live, and confirmed to be working.

Status: Fixed » Closed (fixed)
Issue tags: -drupal.org redesign, -drupal.org redesign project, -drupal.org redesign sprint 3

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +drupal.org redesign, +drupal.org redesign project, +drupal.org redesign sprint 3

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.