We've been working on a site and made some improvements to cod_session, provided here in this patch for easier review.

Key differences:

- Better labels for session flags ("Remove this session from your agenda." etc)
- Export permissions and Session organizer role
- Set permissions for editing session fields.

CommentFileSizeAuthor
#1 cod_session_improvements.patch8.27 KBezra-g

Comments

ezra-g’s picture

ezra-g commented
StatusFileSize
new cod_session_improvements.patch8.27 KB
coltrane’s picture

coltrane
he/him
commented
Status: Needs review » Reviewed & tested by the community 
+++ cod_session/cod_session.features.inc	22 Aug 2010 11:35:30 -0000
@@ -1,55 +1,120 @@
+  'roles' => ¶

Extraneous whitespace

+++ cod_session/cod_session.features.inc	22 Aug 2010 11:35:30 -0000
@@ -1,55 +1,120 @@
+    'flag' => ¶

Extraneous whitespace

+++ cod_session/cod_session.features.inc	22 Aug 2010 11:35:30 -0000
@@ -1,55 +1,120 @@
+    'unflag' => ¶

Extraneous whitespace

+++ cod_session/cod_session.features.inc	22 Aug 2010 11:35:30 -0000
@@ -1,55 +1,120 @@
+  'locked' => ¶

Extraneous whitespace

+++ cod_session/cod_session.features.inc	22 Aug 2010 11:35:30 -0000
@@ -1,55 +1,120 @@
+  'types' => ¶

Extraneous whitespace

+++ cod_session/cod_session.features.inc	22 Aug 2010 11:35:30 -0000
@@ -1,55 +1,120 @@
+  'roles' => ¶

Extraneous whitespace

+++ cod_session/cod_session.features.inc	22 Aug 2010 11:35:30 -0000
@@ -1,55 +1,120 @@
+    'flag' => ¶

Extraneous whitespace

... there's more extraneous whitespace.

Otherwise looks good.

Powered by Dreditor.

ezra-g’s picture

ezra-g commented
Status: Reviewed & tested by the community » Fixed

The whitespace is generated by Features and likely to appear all over the place, so coltrane and I decided to leave it.

Thanks to lisarex for the improved labels here. This is committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

coltrane’s picture

coltrane
he/him
commented
Status: Closed (fixed) » Needs work 
+++ cod_session/cod_session.features.inc	22 Aug 2010 11:35:30 -0000
@@ -1,55 +1,120 @@
-function cod_session_content_default_fields() {
-  module_load_include('inc', 'cod_session', 'cod_session.defaults');
-  $args = func_get_args();
-  return call_user_func_array('_cod_session_content_default_fields', $args);
-}

This shouldn't be removed. If you install cod_support right now you get a broken session feature: no body, and no CCK fields. I think this patch was erroneously created.

coltrane’s picture

coltrane
he/him
commented

It might be worth considering rolling this back till #903910: Recreate features under new API is in. Thoughts?

Edit: The reason is the patch that was committed mistakenly included the partial, but incomplete, upgrade to the new Features include file format. It may be easiest to revert this patch, upgrade to the new format, then commit new improvements.

coltrane’s picture

coltrane
he/him
commented

Now that COD Support is on new file include format and Features 1.0 it's worth re-exporting COD Session for any new features.

lisarex’s picture

lisarex commented

While you are rerolling this, could you also add the "create session content" and "edit any session content" permission for session organizer role?

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

  • ezra-g committed 8ad2e92 on 2281453-cod-drag-n-drop 
    feature #890076 by lisarex and ezra-g: Improvements to Cod_Session...
japerry’s picture

japerry
Location KOMK
commented
Issue summary: View changes
Status: Needs work » Closed (fixed)