As sdboyer point me out, the only missing class is VersioncontrolOperationCache, and it is because it do some statistics stuff(probably replaced in the future to use the now-only-in-our-heads activity table), __but__ there are still some places where we need to remove that!

See git grep getInstance for details:

commitlog/commitlog.module:  $vcs_accounts = VersioncontrolAccountCache::getInstance()->getAccounts(array('uids' => array($account->uid)));
commitlog/commitlog.module:  $operations = VersioncontrolOperationCache::getInstance()->getOperations($constraints, array(
commitlog/commitlog.module:  $operations = VersioncontrolOperationCache::getInstance()->getOperations($constraints, array(
hook_versioncontrol.php: *   return value of VersioncontrolAccountCache::getInstance()->getAccounts(). Entries in this list
hook_versioncontrol.php: *   a structured array like the one returned by VersioncontrolAccountCache::getInstance()->getAccounts().
includes/VersioncontrolOperationCache.php:   * VersioncontrolOperationCache::getInstance()->getOperations().
includes/VersioncontrolOperationCache.php:  public static function getInstance() {
includes/VersioncontrolOperationCache.php:    $repositories = VersioncontrolRepositoryCache::getInstance()->getRepositories(array('repo_ids' => $repo_ids));
includes/VersioncontrolOperationCache.php:   * Convenience function, calling VersioncontrolCache::getInstance()->_get_operations() with a preset
includes/VersioncontrolRepository.php:    // $operations = VersioncontrolOperationCache::getInstance()->getOperations(array('repo_ids' => array($this->repo_id)));
includes/interfaces.inc:   *   VersioncontrolAccountCache::getInstance()->getAccounts().  All
includes/versioncontrol.rules.inc:    $operations = VersioncontrolOperationCache::getInstance()->getOperations(array('vc_op_ids' => array($vc_op_id)));
versioncontrol.admin.inc:  $statistics = VersioncontrolOperationCache::getInstance()->getStatistics(array(
versioncontrol.module: *   Will be passed on to VersioncontrolAccountCache::getInstance()->getAccounts(), see the
versioncontrol_account_status/versioncontrol_account_status.module: *   a structured array like the one returned by VersioncontrolAccountCache::getInstance()->getAccounts().
versioncontrol_account_status/versioncontrol_account_status.module: *   return value of VersioncontrolAccountCache::getInstance()->getAccounts(). Entries in this list
versioncontrol_fakevcs/includes/classes.inc:      $commit_operations = VersioncontrolOperationCache::getInstance()->getCommits($constraints);
versioncontrol_views/handlers/versioncontrol_plugin_row_operation.inc:    $this->operations = VersioncontrolOperationCache::getInstance()->getOperations($constraints);

Marking as bug, as some code is actually called.

Comments

marvil07’s picture

Issue tags: +git phase 2

tagging

webchick’s picture

Priority: Normal » Critical

Marking as critical, to indicate this is a migration blocker.

chrisstrahl’s picture

Issue tags: +git sprint 2

Tagging for git sprint 2

chrisstrahl’s picture

Assigned: Unassigned » sdboyer
sdboyer’s picture

Status: Active » Fixed

Got this done locally, will push back in presently

webchick’s picture

Status: Fixed » Closed (fixed)

Verified.

marvil07’s picture

Status: Closed (fixed) » Needs work
Issue tags: +git sprint 4

some work to do here

$ git grep getInstance
commitlog/commitlog.module:  $vcs_accounts = VersioncontrolAccountCache::getInstance()->getAccounts(array('uids' => array($account->uid)));
commitlog/commitlog.module:  $operations = VersioncontrolOperationCache::getInstance()->getOperations($constraints, array(
commitlog/commitlog.module:  $operations = VersioncontrolOperationCache::getInstance()->getOperations($constraints, array(
includes/VersioncontrolRepository.php:    // $operations = VersioncontrolOperationCache::getInstance()->getOperations(array('repo_ids' => array($this->repo_id)));
includes/interfaces.inc:   *   VersioncontrolAccountCache::getInstance()->getAccounts().  All
includes/versioncontrol.rules.inc:    $operations = VersioncontrolOperationCache::getInstance()->getOperations(array('vc_op_ids' => array($vc_op_id)));
includes/views/handlers/versioncontrol_plugin_row_operation.inc:    $this->operations = VersioncontrolOperationCache::getInstance()->getOperations($constraints);
versioncontrol.admin.inc:  $statistics = VersioncontrolOperationCache::getInstance()->getStatistics(array(
versioncontrol.api.php: *   return value of VersioncontrolAccountCache::getInstance()->getAccounts(). Entries in this list
versioncontrol.api.php: *   a structured array like the one returned by VersioncontrolAccountCache::getInstance()->getAccounts().
versioncontrol.module: *   Will be passed on to VersioncontrolAccountCache::getInstance()->getAccounts(), see the
versioncontrol_account_status/versioncontrol_account_status.module: *   a structured array like the one returned by VersioncontrolAccountCache::getInstance()->getAccounts().
versioncontrol_account_status/versioncontrol_account_status.module: *   return value of VersioncontrolAccountCache::getInstance()->getAccounts(). Entries in this list
versioncontrol_fakevcs/includes/classes.inc:      $commit_operations = VersioncontrolOperationCache::getInstance()->getCommits($constraints);
sdboyer’s picture

Commit log module is, for the moment, dead, so I'm not too worried about that. We do have to update documentation.

sdboyer’s picture

Component: API module » Documentation
Issue tags: -git sprint 4

Shouldn't really have been tagged git sprint 4. And moving to documentation, since that's really what's left here.

eliza411’s picture

Issue tags: +git sprint 8

Tagging git sprint 8

sdboyer’s picture

Now that I've done the hatchet job in #983926: Remove account class, this should be pretty easy.

marvil07’s picture

Assigned: sdboyer » marvil07
marvil07’s picture

Title: remove completely the Versioncontrol*Cache classes » Remove completely the Versioncontrol*Cache classes
Status: Needs work » Fixed
StatusFileSize
new4.41 KB

Last things seems to be trivial, so I committed this patch directly.

Status: Fixed » Closed (fixed)
Issue tags: -git phase 2, -git sprint 2, -git sprint 8

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 46e441e on repository-families, drush-vc-sync-unlock by marvil07:
    bug #890222: Remove completely the Versioncontrol*Cache classes.
    
    

  • Commit 46e441e on repository-families by marvil07:
    bug #890222: Remove completely the Versioncontrol*Cache classes.