As sdboyer point me out, the only missing class is VersioncontrolOperationCache, and it is because it do some statistics stuff(probably replaced in the future to use the now-only-in-our-heads activity table), __but__ there are still some places where we need to remove that!
See git grep getInstance for details:
commitlog/commitlog.module: $vcs_accounts = VersioncontrolAccountCache::getInstance()->getAccounts(array('uids' => array($account->uid)));
commitlog/commitlog.module: $operations = VersioncontrolOperationCache::getInstance()->getOperations($constraints, array(
commitlog/commitlog.module: $operations = VersioncontrolOperationCache::getInstance()->getOperations($constraints, array(
hook_versioncontrol.php: * return value of VersioncontrolAccountCache::getInstance()->getAccounts(). Entries in this list
hook_versioncontrol.php: * a structured array like the one returned by VersioncontrolAccountCache::getInstance()->getAccounts().
includes/VersioncontrolOperationCache.php: * VersioncontrolOperationCache::getInstance()->getOperations().
includes/VersioncontrolOperationCache.php: public static function getInstance() {
includes/VersioncontrolOperationCache.php: $repositories = VersioncontrolRepositoryCache::getInstance()->getRepositories(array('repo_ids' => $repo_ids));
includes/VersioncontrolOperationCache.php: * Convenience function, calling VersioncontrolCache::getInstance()->_get_operations() with a preset
includes/VersioncontrolRepository.php: // $operations = VersioncontrolOperationCache::getInstance()->getOperations(array('repo_ids' => array($this->repo_id)));
includes/interfaces.inc: * VersioncontrolAccountCache::getInstance()->getAccounts(). All
includes/versioncontrol.rules.inc: $operations = VersioncontrolOperationCache::getInstance()->getOperations(array('vc_op_ids' => array($vc_op_id)));
versioncontrol.admin.inc: $statistics = VersioncontrolOperationCache::getInstance()->getStatistics(array(
versioncontrol.module: * Will be passed on to VersioncontrolAccountCache::getInstance()->getAccounts(), see the
versioncontrol_account_status/versioncontrol_account_status.module: * a structured array like the one returned by VersioncontrolAccountCache::getInstance()->getAccounts().
versioncontrol_account_status/versioncontrol_account_status.module: * return value of VersioncontrolAccountCache::getInstance()->getAccounts(). Entries in this list
versioncontrol_fakevcs/includes/classes.inc: $commit_operations = VersioncontrolOperationCache::getInstance()->getCommits($constraints);
versioncontrol_views/handlers/versioncontrol_plugin_row_operation.inc: $this->operations = VersioncontrolOperationCache::getInstance()->getOperations($constraints);
Marking as bug, as some code is actually called.
Comments
Comment #1
marvil07 commentedtagging
Comment #2
webchickMarking as critical, to indicate this is a migration blocker.
Comment #3
chrisstrahl commentedTagging for git sprint 2
Comment #4
chrisstrahl commentedComment #5
sdboyer commentedGot this done locally, will push back in presently
Comment #6
webchickVerified.
Comment #7
marvil07 commentedsome work to do here
Comment #8
sdboyer commentedCommit log module is, for the moment, dead, so I'm not too worried about that. We do have to update documentation.
Comment #9
sdboyer commentedShouldn't really have been tagged git sprint 4. And moving to documentation, since that's really what's left here.
Comment #10
eliza411 commentedTagging git sprint 8
Comment #11
sdboyer commentedNow that I've done the hatchet job in #983926: Remove account class, this should be pretty easy.
Comment #12
marvil07 commentedComment #13
marvil07 commentedLast things seems to be trivial, so I committed this patch directly.