Another thing that we need to solve is that VersioncontrolRepository is a child class of VersioncontrolEntity, so having a $repository data member on the VersioncontrolEntity of VersioncontrolRepository type, does not make architectural sense.

Opening the issue to avoid forgetting it.

CommentFileSizeAuthor
#7 890230-split-repos.patch4.83 KBsdboyer

Comments

marvil07’s picture

marvil07 commented
Issue tags: +git phase 2

tagging

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Re-thing relation between entity and repo classes » Re-think relation between entity and repo classes
Priority: Normal » Critical

Marking as a critical release blocker for the migration.

chrisstrahl’s picture

chrisstrahl commented
Issue tags: +git sprint 2

tagging as git sprint 2

chrisstrahl’s picture

chrisstrahl commented
Assigned: Unassigned » sdboyer
sdboyer’s picture

sdboyer commented

Simple enough to solve this - I added a VersioncontrolEntityInterface which VersioncontrolEntity now implements. VersioncontrolRepository implements VersioncontrolEntityInterface directly and does its own thing, and the rest use VersioncontrolEntity as a base class.

Not in CVS yet because its wrapped up in #879858: Unify entity C(R)UD .

sdboyer’s picture

sdboyer commented
Status: Active » Fixed
sdboyer’s picture

sdboyer commented
StatusFileSize
new 890230-split-repos.patch4.83 KB

I unwrapped it from the other stuff, and I've attached it in this patch. Haven't actually committed it because I'm trying to get the damn tests to work first. Ugh.

sdboyer’s picture

sdboyer commented

I'm not gonna wait on those tests to commit it, since there are the same failures as exist already in HEAD. So the patch from #7 is in.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Fixed » Closed (fixed)

Verified.

  • Commit b511cc4 on repository-families, drush-vc-sync-unlock by sdboyer: 
    Issue #890230: introduce a VersioncontrolEntityInterface and use it to...
  • Commit 94fd177 on repository-families, drush-vc-sync-unlock by sdboyer:
    Follow-up to #890230 - forgot to add the new interface to the autoload...

  • Commit b511cc4 on repository-families by sdboyer: 
    Issue #890230: introduce a VersioncontrolEntityInterface and use it to...
  • Commit 94fd177 on repository-families by sdboyer:
    Follow-up to #890230 - forgot to add the new interface to the autoload...