Think in the possibility to do that, so, add a comment to add the new possible return(FALSE) to the documentation or return the empty array.

If we stay with the FALSE return, we need to validate it on the calling or decide that the warning is ok.

Comments

marvil07’s picture

marvil07 commented

just to mention that the empty array is the actual behaviour of out load method on VersioncontrolEntity, so it seems like a good idea to do the same here :-)

marvil07’s picture

marvil07 commented
Issue tags: +git phase 2

tagging

sdboyer’s picture

sdboyer commented
Issue tags: +git sprint 2

tagging for sprint 2

chrisstrahl’s picture

chrisstrahl commented
Assigned: Unassigned » sdboyer
sdboyer’s picture

sdboyer commented
Status: Active » Fixed

Fixed locally, will move back into CVS presently

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Fixed » Closed (fixed)

Verified.

  • Commit 418e760 on repository-families, drush-vc-sync-unlock by sdboyer: 
    Issue #890232: return an empty array instead of FALSE on failure from...

  • Commit 418e760 on repository-families by sdboyer: 
    Issue #890232: return an empty array instead of FALSE on failure from...