Hi all, thanks for the great module, I'm using it in a few sites and it's very handy.

One thing that, imho, is missing is the ability to show the panel by default, i.e. adding an "Expanded" option in the "State on new pages" select. So that the panel will show expanded by default on every page.
I would love to have the panel expanded for admin pages by default, but remember if the user collapses the panel, kind of being able to change the default state from collapsed to expanded and then selecting the "Remember from previous pages" option...
What do you think?

I hope you'd like this idea.

Thank you!

CommentFileSizeAuthor
#2 expanded-by-default-option-890392-2.patch4.62 KBgaëlg

Comments

m-si’s picture

m-si commented

I would love to have that function as well, but I think it would need a separate radiobutton on the admin page "Expanded after login" and "disable collapsabilty" at all. Because some not very webish people keep on giving me a call "...where has the menu gone".

Thank you for the great module

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Status: Active » Needs review
StatusFileSize
new expanded-by-default-option-890392-2.patch4.62 KB

This patch adds a new select element on the settings page, to choose if the admin menu should be expanded or collapsed on the initial page. And it also alters the "behavior on new pages" element to replace "collapsed" by "same as init page". So that 4 combinations are possible :

  • collapsed first then remember (it is still the default behavior so that people can update the module with no unwanted effect)
  • collapsed for each new page (was available before)
  • expanded first then remember (new option)
  • expanded for each new page (new option)

Of course, when on a page, you can show/hide the menu as many times as you want, as before.

@maintainer : I found something which looks like a little error in the code : $_REQUEST was used to retrieve a cookie, but actually it's in $_COOKIE. This had probably no effect, at least for people who had js enabled. It's repaired in the patch.
But maybe we should use the drupal session cookie instead, for the custom setting to be lost at logout, so that the behavior at login time remains the same every time ?

sickness29’s picture

sickness29 commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

Development or support is not planned for D6. All D6-related issues are marked as outdated in a bunch.

Everyone can apply the patch above (not tested by the maintainers, tested by the community) to their D6 projects.
If the issue remains relevant for D10+ versions, merge requests with proposed solutions for a new module version (D10+) are welcome in a new follow-up issue.

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.