Backport latest SimpleTest code from D7

I'm confused, this seems to be a patch against core as well as Simpletest?

Nevermind, patching a patch file is as confusing as patching a patch file which is....

+1 Badly needed.

However, I'm mainly interested in newly introduced assertion methods and stuff. Would it be possible and would it make sense to split those "feature" changes into a separate patch?

I'm not really interested in changing the fundamental D6 implementation of SimpleTest. Also not sure whether that shouldn't require a new major version for this module.

Getting

Fatal error: Call to undefined function drupal_static() in /Users/mdp/www/6/sites/all/modules/simpletest/simpletest.module on line 300

Whats your plan for this, want to backport drupal_static or patch where necessary?

I think somewhere there is a module that backports a bunch of stuff (like drupal_static) to D6. This is already likely to be dependent on Autoload for D6.

xpost

Ensure #699216: Module dependencies not being checked in SimpleTest 6.x (and needs doc) works.

More to check:
- #789188: Wrong path listed for viewing results
- #803026: Fatal error on simpletest: Unsupported operand types in form.inc on line 518
- #892446: Backport drupal_hmac_base64 so drupal_generate_test_ua makes valid headers.
- #382334: drupalGetNodeByTitle doesn't return node object
- #869408: curlHeaderCallback() should join headers if no colon found

Cleaned up existing issue (thus the list above) and created 6.x-2.11 so the backport will be 2.12.

This issue should be backported when commited #278425: Using basename() is not locale safe

Kinda tricky tracking all these in one issue but... here's the backport drupal_hmac_base64 patch. Its sort of critical because d6 simpletest is not reliable enough to use without it. Any set of tests of sufficient size will fail somewhere logging in a user or testing some form.

Sorry, correct format and a patch to apply over the previous core patch for testing.

@davereid, What ended up being the status of this?

+++ drupal_web_test_case.php	29 Jan 2011 17:46:22 -0000
@@ -979,7 +1042,7 @@ class DrupalWebTestCase extends DrupalTe
-    $account = user_save('', $edit);
+    $account = user_save(NULL, $edit);

Not sure whether this is correct for D6 -- did you double-check that with user_save() in detail?

+++ simpletest.module	29 Jan 2011 17:46:22 -0000
@@ -55,7 +55,6 @@ function simpletest_menu() {
     'page arguments' => array('simpletest_result_form', 4),
     'description' => 'View result of tests.',
     'access arguments' => array('administer unit tests'),
-    'type' => MENU_CALLBACK,

Did you manually run a test and verify that

1) the proper page title is displayed

2) the proper breadcrumb is displayed

?

Powered by Dreditor.

Thanks for double-checking, and committing, @Dave Reid! :)

+1

This still hasn't been ported over #892446-1: Backport drupal_hmac_base64 so drupal_generate_test_ua makes valid headers.

I would but I get random 500 invalid header failures breaking tests. :)

Seriously though, I think it is unfortunate that we're blocking a fairly critical bug fix in favor of an amorphous "Backport everything from 7" issue. That's the only reason I bumped the issue.

Drupal 6 is no longer officially supported. If you think this issue is still relevant for 8.x, feel free to re-open.