clicking login from the url under a comment produces 404 error (clean urls)

Hmm... I believe passing the anchor to drupal_urlencode() is intentional and desirable, since the anchor #comment_form doesn't apply to the login page, but rather to the post-login redirect as specified by the destination= parameter.

This means the bug is either in drupal_urlencode() or the post-login redirection code.

Note related issue #88050.

I ran into the same problem. I fixed it by adding urldecode to drupal_goto.

This bug is present in 4.7 an dHEAD and currently manifests on drupal.org itself.

Marking as critical, since it's obviously going to leave a very bad impression on any new user who gets a "page not found" when first registering or logging in.

This problem only occurs when site is using clean urls, drupal_urlencode prepends %25 to #(%23) and &(%26) when clean urls is true...

Rerolled patch against head and have tested the patch from #3 and it does solve the problem. since the values of destination are sent to drupal_goto, i think it is fine to have urldecode there (cant see anwhere else of putting it :( )....

another way of going about this is to not urlencode the destination values when clean url is on. (doesnt sound like a good to me.)

Committed to HEAD.

backport.

@andeeeb: Please create patches against the base Drupal directory; i.e. your patch should be a diff for includes/common.inc rather than drupal/includes/common.inc.

-K

applied