Posted by birwel on August 23, 2010 at 10:36am
2 followers
Jump to:
| Project: | Simplenews Digest |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
in line 419 of the digest node function there is a filter format assignment
$node->filter = variable_get('filter_default_format', 1);this i wrong because the filter member doesn't exists, use format instead:
$node->format = variable_get('filter_default_format', 1);
another issue is that if using better_formats module, the format is not set properly.
It would be a good idea to add support for it, for example:
if(function_exists('better_formats_get_default_format'))
$node->format = better_formats_get_default_format('node', $node->type);Hope it helps
Comments
#1
Thanks! I've applied the change in line 419. I'm waiting for the next newsletter to see if it was successful.
I'm also using better_formats.module . Where should I paste the code:
if(function_exists('better_formats_get_default_format'))$node->format = better_formats_get_default_format('node', $node->type);
At the end of the module is ok?
By the way, the issue I'm facing is that the newsletter content is in one line, there are no line breaks. I've mime module installed.
#2
The better formats suggestion :
In line 420, replace:
<?php$node->format = variable_get('filter_default_format', 1);
?>
by
<?php
if(module_exists('better_formats')){
$node->format = better_formats_get_default_format('node', $node->type);
}
else{
$node->format = variable_get('filter_default_format', 1);
}
?>
By the way is there any maintainer that fixes/closes, etc the issues ?