Currently, some Views have capitalized names and others have all lowercase names with words separated by underscores. Some of the latter begin with commerce_ while others do not. We should get a unified way of naming Views and stick to it, and my hunch is we should have decent descriptions to boot. I'm open to anything consistent, and I'd probably prefer the commerce_ prefix with no more capitalized names.

Comments

neokrish’s picture

neokrish commented

this is really low hanging. I could do this.

I have cloned git repository of Commerce on my local system. How do you want to report back the changes which will be plug and play for you?

thanks,
neokrish

rszrama’s picture

rszrama commented

You can either post a patch in here or just paste a link to the relevant commit in your GitHub repo (if you're on GitHub). It's pretty easy to review changes using their UI, and then I can pull the change into my repo directly there, too.

neokrish’s picture

neokrish commented

Ryan, I have made the commits requested at http://github.com/neokrish/drupalcommerce/commit/62bdc518338116fc7356f1b... . Is this the way you wanted the changes to report?

Also do you have any idea about why github shows "unknown (author)" instead of neokrish (my username) in the commit message? I am using Aptana Studio 3 to push my commits.

neokrish’s picture

neokrish commented
Assigned: Unassigned » neokrish
rszrama’s picture

rszrama commented
Status: Active » Needs review

This looks great. I'll test it hopefully later this evening and get it committed.

As for not having your name, I'm not sure I've ever seen that. : P

Look through the GitHub documentation for committing to a repository to find out how it recognizes your commits... I think it might have to do with e-mail address or something in your Git config. It should be pulling that information from your repository configuration, so perhaps Aptana doesn't have that set right somehow?

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Committed with a minor change to generalize a description. Thanks!

rszrama’s picture

rszrama commented

Just in case anyone runs into this, this patch introduce a bug that I've since patched when viewing an order. The display formatter for the line item reference field wasn't updated to use the new View name. Will get it deployed to CVS ASAP, but I have some other work in progress code in my repo that I can't push yet. Refer here for the fix:

http://github.com/rszrama/drupalcommerce/commit/eadf637f38f3a99996b66c2c...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

neokrish’s picture

neokrish commented

just a quick note to all that the patch at #7 has been merged with the master branch by rszrama.