The tableselect element processing always adds a column to the output table for the check boxes or radio buttons, but does not always add a column header. If a tableselect item has #multiple_value = FALSE, then a column header is missing in the table.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 891476-core-tableselect.patch | 1001 bytes | solotandem |
| #7 | 891476-core-tableselect.patch | 807 bytes | solotandem |
| #5 | 891476-core-tableselect.patch | 991 bytes | solotandem |
| #4 | 891476-core-tableselect.patch | 690 bytes | solotandem |
| #1 | 891476-core-tableselect.patch | 691 bytes | solotandem |
Comments
Comment #1
solotandem commentedComment #2
boombatower commentedlooks good
Comment #3
heine commentedDuplicate of #888782: regression: tableselect headers misaligned when #js_select is FALSE. But since this exact same patch is RTBC, marking that one closed.
Comment #4
solotandem commentedRerolled.
Comment #5
solotandem commentedAdded comment at suggestion of webchick.
Comment #7
solotandem commentedRevised comment from IRC discussion with Heine.
Comment #8
heine commentedThe comment is misleading; the empty header is not only necessary when displaying radios, but also when the select-all checkbox is not displayed when checkboxes are displayed. In either case #js_select is FALSE.
Comment #10
solotandem commentedReworded the comment and rerolled against HEAD.
Comment #11
ruharen commentedIgnore this. My mistake.
Comment #12
sun#10: 891476-core-tableselect.patch queued for re-testing.
Comment #13
sunAlthough badly needed, this is D8 material according to the rules (I had to learn today). It may be backported at a later point in time (though that's unlikely).
Comment #14
heine commentedI call BS on this. I also don't feel happy that this simple comment change is collateral damage / serves as counter example in some policy fight.
Comment #15
dries commentedCommitted to CVS HEAD. Thanks.