When using ctools modals with forms, we have to manually set the title. Why not use a default of drupal_get_title()? Then all we need is to put the title in the form's menu callback or call drupal_set_title() in the form callback itself.

CommentFileSizeAuthor
#2 891682-ctools-modal-default-title.patch891 bytesDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

That's a darn good question. I'd make it a fallback so it doesn't overwrite a title that's explicitly set, but I can't think of a single reason not to do that.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Active » Needs review
FileSize
891682-ctools-modal-default-title.patch891 bytes

This greatly helped a mass implementation of modals in XML sitemap. Ready for review.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.