Download & Extend
Issues

Usability: Better message on module activation/deativation

Posted by Frando on October 14, 2006 at 2:34pm
Project:Drupal core
Version:8.x-dev
Component:user interface text
Category:task
Priority:normal
Assigned:rocket_nova
Status:needs review
Issue tags:ui-text, Usability

Issue Summary

If you enable a module, it would be great to get a list of administrative tasks associated with this module instead of the message "The configuration options have been saved".

Inspired by the new "Administer by module"-page I did some work in improving this message.

I think this is quite useful especially for not-so-experienced administrators.

Patch is attached, screenshot will follow.

AttachmentSizeStatusTest resultOperations
modulemessage.patch4.04 KBIdleFAILED: [[SimpleTest]]: [MySQL] Invalid patch format in modulemessage.patch.View details | Re-test
Login or register to post comments

Comments

#1

Posted by Frando on October 14, 2006 at 2:36pm

Screenshot.

AttachmentSizeStatusTest resultOperations
screenshot_30.png23.77 KBIgnoredNoneNone

#2

Posted by dww on October 15, 2006 at 4:31pm

the only problem with this approach is that the messge is totally transient, and will disappear as soon as the admin does anything else (like click on one of those tempting new links). i'd rather see these links right next to the modules all the time (which was being debated and might already be in core by now, i've been too busy on the new release system to keep up with core checkins for the last week). once that "links" patch goes in (don't know the # off the top of my head), maybe the message in this box should just mention something like: "You can find links to administrative tasks for each new module in the table below" after the list of all the ones that were added...

my $0.02, at least...
-derek

#3

Posted by Dries on October 15, 2006 at 8:46pm

Note sure. Looks nice on the one hand, but bloated on the other hand. Maybe it would be better to link to the correct section of the 'admin/by-module' page? That would simplify things a little, and actually teached people about the existence of that page.

#4

Posted by Frando on October 20, 2006 at 2:41pm

Yes, might be true.
So what about something like that?

AttachmentSizeStatusTest resultOperations
system2.patch3.85 KBIdleFAILED: [[SimpleTest]]: [MySQL] Invalid patch format in system2.patch.View details | Re-test

#5

Posted by Frando on October 20, 2006 at 2:42pm

screenshot

AttachmentSizeStatusTest resultOperations
modulescreen.jpg46.66 KBIgnoredNoneNone

#6

Posted by profix898 on October 20, 2006 at 3:47pm
Status:needs review» needs work

I really like the new approach. It presents a clearly arranged list of what happened and provides a link to admin-by-module page.
But there are some issue with the patch:

  • Code-style needs work, e.g. foreach() {...} missing braces
  • Messages should be unified, e.g. only disabled/enabled OR has been ... in both cases
    (atm it is 'Module X enabled' and 'Module X has been disabled')
  • Maybe you should create a theme_ function to format the list to make it themable
  • Whats the reason for extracting the admin-by-module code into its own function (system_get_admin_tasks)? You dont need this anymore for the patch, right? But I agree it doesnt hurt and might be used by other modules.

All in all nice patch :)

#7

Posted by L4san on April 7, 2008 at 1:18pm
Version:x.y.z» 7.x-dev

Frando: Is this task still in progress?

Moving to cvs.

#8

Posted by Frando on April 8, 2008 at 11:12pm
Assigned to:Frando» Anonymous

Um, no - I'm travelling currently and therefore unable to do any actual coding. Should be really easy, though.

#9

Posted by Sutharsan on August 31, 2008 at 3:44pm
Component:system.module» usability

Moving all usability issues to Drupal - component usability.

#10

Posted by heather on October 25, 2009 at 4:45pm
Component:usability» user interface text

A slightly related issue: to bring an 'edit configuration' or settings link into the module listing. People on this issue might be interested to review: #598758: Modules page: add link to its settings page for each module

#11

Posted by heather on October 25, 2009 at 4:47pm
Component:user interface text» other

oops i didn't mean to change component.

#12

Posted by Bojhan on January 9, 2010 at 9:14pm
Version:7.x-dev» 8.x-dev

This looks like Drupal 8 work

#13

Posted by rocket_nova on November 26, 2011 at 7:27pm
Component:other» user interface text
Assigned to:Anonymous» rocket_nova
Status:needs work» needs review

I also think this would be a helpful addition. Re-rolled patch for #4.

AttachmentSizeStatusTest resultOperations
module-list-89205-13.patch1.01 KBIdleFAILED: [[SimpleTest]]: [MySQL] 34,005 pass(es), 87 fail(s), and 0 exception(es).View details | Re-test

#14

Posted by System Message on November 26, 2011 at 8:10pm
Status:needs review» needs work

The last submitted patch, module-list-89205-13.patch, failed testing.

#15

Posted by joachim on November 27, 2011 at 5:36pm

Looks like EnableDisableTestCase::testEnableDisable needs to be changed to account for the new message.

Also, there's stray whitespace in the patch.

But definitely a good thing -- and would save contrib modules from adding these sorts of messages in hook_enable().

#16

Posted by rocket_nova on November 27, 2011 at 5:54pm
Status:needs work» needs review

Re-rolled patch with updates to appropriate tests.

AttachmentSizeStatusTest resultOperations
module-list-89205-15.patch7.36 KBIdlePASSED: [[SimpleTest]]: [MySQL] 34,132 pass(es).View details | Re-test

#17

Posted by yoroy on November 28, 2011 at 3:34pm

Thanks for the reroll. I'm still struggling with applying patches. In the mean time, could somebody update the screenshot? Last we have is this:

the message after enabling modules adds a link to 'show administration options for all modules'

#18

Posted by Rob Loach on November 29, 2011 at 3:41am

Related: #1291592: D8UX: Batch API for the Modules page

nobody click here