seanburlington [sean]

To confirm, I reviewed the code for vulnerabilities and against http://drupal.org/writing-secure-code and I didn't find anything. I didn't really review the code otherwise.

• This is a partial review; I didn't check all the module code.
• The points reported in this review are not in order of importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1.  /**
     * 
     * @file schema specification for ckan_package
     *
     * @author Sean Burlington sean@practicalweb.co.uk
     * 
     *
     * This module was created for http://data.gov.uk a key part of the UK Government's Transparency programme.
     * It's under constant development and we want to work with you to make it and open data better.
     *
     * @copyright Crown copyright
     * @license http://www.gnu.org/licenses/gpl-2.0.html
     *
     *  This program is free software: you can redistribute it and/or modify
     *  it under the terms of the GNU General Public License as published by
     *  the Free Software Foundation, either version 2 of the License, or
     *  (at your option) any later version.
     *
     *  This program is distributed in the hope that it will be useful,
     *  but WITHOUT ANY WARRANTY; without even the implied warranty of
     *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     *  GNU General Public License for more details.
     *
     *  You should have received a copy of the GNU General Public License
     *  along with this program.  If not, see <http://www.gnu.org/licenses/gpl-2.0.html>.
     *
     */
   
   

   Any reference to the license used should be removed from the code.
   The copyright statement would not be anymore exact from the moment you accept patches created by other users. To make a comparison, Drupal is not reported to be copyrighted from Dries Buytaert; it is reported to be copyrighted from each contributors.

2. Menu descriptions and titles, as well as schema descriptions, are not passed to t().
3. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted.
4. The module doesn't implement hook_uninstall().

5.   $form['ckanpackage']['ckanpackage_feedback'] = array(
       '#type' => 'textfield',
       '#title' => t('Contact addresses for package fedback'),
       '#default_value' => variable_get('ckanpackage_feedback', ''),
       '#size' => 40,
       '#description' => t('Comma seperated email addresses. Package feedback will be sent to these in addition to contact emails in the package data.'),
     );
   
   

   Seperated?

6. function ckanpackage_package_list($names_only = FALSE) {
     $package_list = array();
     $res = db_query("select nid, ckan_name from {ckan_package}");
     while ($row = db_fetch_array($res)) {
       $package_list[] = $names_only ? $row['ckan_name'] : $row;
     }
     return $package_list;
   }
   
   

   Reserved SQL keywords are written in uppercase.

7.   $form['ckan_name'] = array(
         '#title'         => t('Name'),
         '#description'   => t('lowercase alphanumeric and underscores only. Becomes part of the URL'),
         '#type'          => 'textfield',
         '#default_value' => $node->ckan_name,
         '#maxlength'     => 100,
         '#required'      => TRUE,
     );
   
   

   The description should be a sentence starting with a capitalized word, and ending with a period.

Anarcat has indeed approved seanburlington to co-maintain http://drupal.org/project/mediawikiauth.

I approved the CVS account as co-maintainer.

@seanburlington is the copyright issue solved? would love to see this module on d.o.

this is the licence corresponding to the "crown copyright" http://www.nationalarchives.gov.uk/doc/open-government-licence/

right?

we have to overcome the obstacles and publish this module - in future this is going to be crucial for the success of open source modules published by governments.

Subscribe, are license issue resolved ?

Thanks.

For reference, module is now published on http://www.drupal.org/project/ckan

But there are not any releases....

@paolomainardi It seems so far it is only available in Git: http://drupalcode.org/project/ckan.git/tree/refs/heads/6.x-1.x

Blocking the comments, as the issue report is being wrongly used.