I've a child content type with two fields:

  • a requied node reference, called "Telecentro" .
  • a required date with time (hour and minutes) called "Fecha y Horario". The "to date" option is marked as required too.

This content type is referenced by a nodereference/node_widget field called "field_convocatorias" inthe parent content type.

When I edit a parent node and try to add a child node, filling correctly all fields, it shows me the error:

    * warning: Invalid argument supplied for foreach() in [path to project]/sites/default/modules/date/date/date_elements.inc on line 436.
    * There are errors in Fecha y Horario:
          o Some value must be entered in the To date.
          o The To date must be greater than the From date.

I tried to follow the code down to the error and seems like the date/date_elements.inc/date_combo_validate($element, &$form_state) function is using the '#post' data as it were at first level of the form (in the main page form) but the real data is down in a node_widget subform the date module do not knows nothing about: it expect the data in $element[#post][field_convocatorias][0] but it's in $element[#post][field_convocatorias][0][node_widget].

CommentFileSizeAuthor
#2 node_widget_patch_892152.txt5.3 KBrgrocha
#1 node_widget_patch.txt4.82 KBrgrocha

Comments

rgrocha’s picture

rgrocha commented
StatusFileSize
new node_widget_patch.txt4.82 KB

I've created a patch to solve this problem.
It also solves some others issues we had in our current project:
- allows multiple values for any child node field (currently tested on dates and text fields)
- support for date_repeat and date_popup_repeat field types
- adds support for other node-processing modules via the hook_nodeapi function (tested with the auto_nodetitle module)
- adds support for the save_edit module. The module now only checks for "submit" Drupal core button.

I've also integrated the path from #791074: Skip does not work if CCK field is required.

I'f using jquery_update you must also apply the patch from #775162: tabledrag.js missing core patches, errors with nested <table>s to support nested tables.

rgrocha’s picture

rgrocha commented
StatusFileSize
new node_widget_patch_892152.txt5.3 KB

A new version of the patch.

Crom’s picture

Crom commented

Thanks for the patch rgrocha. I came across the same date problem as you and then found your patch!

But, when I apply the patch to the current dev (as at 2011-08-19) the parent node saves but the child nodes do not save.

I am going to go back and apply the patch to the current release version and see if that works as it doesn't look like your patch made the current dev version.

Do you have a working version of the module that you could post here?

Thanks,
Crom

Crom’s picture

Crom commented

I think I've found my issue. In node_widget.form.inc your patch creates a $submit_buttons array. I needed to add 'node_form_submit' to this array to get the child nodes to save. The function is now:

function node_widget_node_form_submit(&$form, &$form_state) {
  $submit_buttons = array (
    'submit',                      // Core Drupal
    'redirect_save_edit_submit',   // save_edit module
    'node_form_submit',  
  );

  //if (in_array('node_form_submit', $form_state['clicked_button']['#submit'])) {
  if (count(array_intersect($submit_buttons, $form_state['clicked_button']['#submit']))) {  
    foreach (node_widget_get_fields($form) as $field_name => $field) {
      $node_widget = new node_widget($field, $form, $form_state);
      foreach ($node_widget->get_children() as $delta) {
        if ($nid = $node_widget->submit($delta)) {
          $form_state['values'][$field_name][$delta]['nid'] = $nid;
        }
      }
    }
  }
}
TheDanScott’s picture

TheDanScott commented

Hi rgrotcha / Crom.

Thanks for your efforts on this - I'm experimenting with this patch now to solve an issue I have been having (I had actually resorted to using two separate date fields to get around the validation issues with the "to date" part of a date field).

I'm having a separate issue, which is possibly related to similar issues to the ones you have been fixing here (in that a node with optional fields, other than a single required date field is still seen as "empty" and thus not submitted when the date field is filled in!). I've posted a separate issue at http://drupal.org/node/1342144

I don't suppose either of you would be able to point me in the right direction here?

Cheers

Daniel

TheDanScott’s picture

TheDanScott commented

In further testing with this patch, against the current dev release of the node widget module I've found that multi-value file upload / picture upload fields (and possibly others) become broken.

With the patched node widget module active, when uploading files, the surrounding content-multiple table gets reloaded nested within itself.

Sadly I've had to go back to the beta4 release of node widget and put the two separate date fields back :S