The database tables should not use auto_increment in their primary keys (for database compatibility reasons). Here's a patch to safely switch them to using the sequences table and the db_next_id() function.

CommentFileSizeAuthor
#11 imagecache_install_0.patch4.27 KBquicksketch
#9 imagecache_install.patch0 bytesquicksketch
#5 2imagecache_remove_auto_inc_0.patch8.07 KBquicksketch
#4 2imagecache_remove_auto_inc.patch5.76 KBquicksketch
#2 imagecache_remove_auto_inc.patch5.01 KBquicksketch
imagecache_remove_autoinc.patch4.92 KBquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Needs work

Hmm, looks like the changes to imagecache.module required in this patch are too close the lines changed in the imrove admin interface patch. The two patches cannot be applied on top each other without a conflict. After the admin interface patch is applied I'll roll another patch for this.

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new imagecache_remove_auto_inc.patch5.01 KB

This new patch applies cleanly AFTER running the patch for Issue 89164.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs work » Needs review
quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new 2imagecache_remove_auto_inc.patch5.76 KB

My PGSQL is a little weak. Here's another patch which will accommodate pgsql users upgrading.

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new 2imagecache_remove_auto_inc_0.patch8.07 KB

Due to my shaky pgsql I downloaded a copy just to test out everything. I've learned a lot about pgsql and I'm confident this patch will work great on both mySQL/PGSQL. I also added in a few lines to ensure that mySQL 4.1 creates proper UTF8 tables.

dopry’s picture

dopry commented

committed as 1.9.2.6 with a couple minor fixes and clean up to work with my last commit.

quicksketch’s picture

quicksketch
he/him
commented

Figures this is all out of date now with the latest changes ;-).

@dopry Want me to roll a patch to the latest 4.7 branch or should I leave it to you?

dopry’s picture

dopry commented
Status: Needs review » Fixed

oh yeah... fixed.

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new imagecache_install.patch0 bytes

You'd like to think so wouldn't you! ;-)

This includes corrections to the pgsql and adds UTF8 to mySQL table creation. Thanks!

dopry’s picture

dopry commented

Can you repost, it came in 0 length.

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new imagecache_install_0.patch4.27 KB

Man, cross-developer patch craziness! Here it is again.

dopry’s picture

dopry commented

commited latest patch... btw... all the tabled have also been switched to singular names and all occurences of ruleset should be preset now.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)