Closed (fixed)
Project:
The Great Git Migration
Component:
Commit access process
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
24 Aug 2010 at 18:59 UTC
Updated:
29 Dec 2010 at 19:59 UTC
One of the things we talked about at the Core Developer Summit was expanding #720670: Figure out wording of the "Yes, I promise to upload GPLv2+ code" checkbox to also cover a "Developer Code of Conduct", basically similar to our CVS application requirements. Probably mentioning things like "collaboration over competition", "adherence to coding standards", and so on.
Comments
Comment #1
pwolanin commentedWhat are the essential things?
I promise to only push GPL v2+ code
I will cooperate with the Drupal Security Team as needed
I will treat people with respect in the issue queues
I agree to the Drupal Code Repository TOS. http://drupalcode.org/viewvc/drupal/contributions/TERMS.txt?view=co
It would be nice to limit this to ~4 checkboxes with a line of text (+link) for each.
I don't think collaboration, coding standards, or anything similar should be a bar to pushing code to a git repo.
Comment #2
webchickMoving to The Great Git Migration project, since it's not directly related to infrastructure.
Comment #3
webchickThere was a discussion about this at DCCPH needs summarizing.
Comment #4
rfayContinuing on from @pwolanin's #1:
I will "Step down considerately", from DCOC.
Otherwise, it seems to me basically that he has it.
Comment #5
zzolo commentedSo, I agree, I think it is best to keep this to a minimal agreement with some links. I would suggest the following:
Suggestion for wording:
Comment #6
sdboyer commentedI like the ideas I'm seeing here, but I feel the need to mull this over some more before making any kind of definitive recommendation.
Comment #7
sdboyer commentedOK yep, I'm happy with what zzolo has laid out in #5. If it passes muster with legal, let's make it definitive.
Comment #8
eliza411 commentedI'm assigning this to me until legal agrees to look this over.
Comment #9
Crell commentedWell then tag it for Legal. :-)
I'll have a closer look soon. I'm at work at the moment.
Comment #10
Crell commentedA few tweaks to the language above:
I will only commit GPL v2+-licensed code and resources to the Drupal code repository.
I will only commit code and resources that I own or am permitted to distribute.
I will cooperate with the Drupal Security Team as needed.
I have read and will adhere to the Drupal Code of Conduct.
I agree to the Drupal Code Repository Terms of Service.
I added "-licensed" to the first item and reversing some wording in the 3rd-now-4th item. The new second point is slightly distinct from the first, and is important. If someone is working for a company that doesn't want their code distributed, the person actually writing it is not allowed to distribute it. It's mostly a formality to remind people of that fact, as well as a CYA for us.
I actually have a few quibbles with the Repo TOS, now that I read it, but that's for another thread I think.
Comment #11
eliza411 commentedBack to you, Sam. It looks ready to me.
Comment #12
rfayRelated discussion about privileges and how you get them in git and what they are: #703116-92: Our CVS account application requirements are obtuse and discourage contributions.
We don't seem to have captured the discussion about how git privileges will be allowed, so I tried to report it there. If there's an issue open for that in this project, we should get that over here.
Comment #13
eliza411 commentedTagging Sprint 4 now that we have legal oka.
Comment #14
eliza411 commentedTagging for consideration in git sprint 5
Comment #15
sdboyer commentedWe've got our mandate, people - here are our checkboxes!
Thanks, Crell. We're going to have to figure out where to put the repo ToS now, and make some tweaks to it so it's git-friendly (e.g., "The Drupal Contributions repository" won't actually exist anymore).
Comment #16
webchickEr. 5 checkboxes? :(
Can't we have a textbot/bulleted list that includes all of that text and a single "I agree" button/checkbox?
(answer in IRC: "Yes". Hooray! :D)
Comment #17
sdboyer commentedAnd by "checkboxes" I mean "checkbox" - let's just have one checkbox for all five of those items, which can be in a bulleted list.
Comment #18
pwolanin commentedIs one checkbox enough? Seems like the top items, the code of conduct, and ToS might all deserve their own.
Comment #19
webchickWell, you can't get in unless you agree to all of it. Why bother with needless extra clicking?
Comment #20
pwolanin commented@webchick - "but I just clicked the checkbox near the top, I didn't think I was actually agreeing to the ToS..."
We are lowering the bar a lot - I'm not sure that 3 clicks is too much to ask.
Comment #22
sdboyer commentedadding a git decisions tag to ease finding later