If you upload an mp3 with spaces in the filename, the resulting feed leaves those spaces as is instead of changing them to %20. This makes the feed break in iTunes (some versions at least) and not validate in feedvalidator.

Arguably minor, but it's a bit too easy for a user to break a feed, with no real feedback as to what went wrong.

CommentFileSizeAuthor
#5 spacing_in_filename-892690-5.patch560 bytesewills

Comments

drewish’s picture

drewish commented

I looked around a bit to see if i could find documentation on if the enclosure should be URL encoded and couldn't find anything definitive. What's the error that feed validator is reporting?

mattgilbert’s picture

mattgilbert commented

For a file named "1 1.mp3", Feedvalidator says "line 28, column 1: url must be a full URL: http://example.com/files/1 1.mp3"

Documentation on the error here: http://feedvalidator.org/docs/error/InvalidURLAttribute.html

drewish’s picture

drewish commented

what are you using to upload the files?

mattgilbert’s picture

mattgilbert commented

It's a single filefield, using the regular file upload widget. Firefox.

ewills’s picture

ewills commented
Status: Active » Needs review
StatusFileSize
new spacing_in_filename-892690-5.patch560 bytes

May have come 2 years too late, but I've just come across this issue and written a tiny patch to fix it, attached.