oembedcore.admin.inc and the various CRUD functions can be replaced with a ctools plugin to implement the ctools exportable UI that was introduced in ctools 1.7. I have a patch that is 80% there... Some things don't work quite right, but presets and providers can be loaded and saved. And what's most important is that they can now be exported with Features!

I'll post the patch ASAP. It probably won't be ready to review though.

CommentFileSizeAuthor
#2 oembed.zip23.19 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented

I don't know if I can create this patch... I can make the code work.

  • oembedcore.admin.css, oembedcore.admin.inc go away entirely.
  • oembedcore_menu() goes away entirely.
  • implementations of hook_default_oembedcore_provider() are moved to their own include files.
  • all preset and provider CRUD functions go away entirely.

but the sticky points are:

  • I can't figure out how to "fake add" the plugin files that are deep in new directories because fakeadd won't let me add directories and won't let me add files whose parent directory don't have a CVS directory.
  • I have a bunch of other uncommitted, unreviewed patches for this project that are mixed up in the code I want to make into a patch of.
Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new oembed.zip23.19 KB

Here's a ZIP of my module code base. It's checked out from CVS, but it's got lots of other patches (in the queue) and hacks (not in the queue).

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

I've finished the patch.

http://github.com/bangpound/drupal-oembed/commit/b3bf162e73c458bb198ba5d...

voxpelli’s picture

voxpelli commented
Status: Needs review » Needs work

By adding 'api' to the schemas you're breaking compatibility with all existing exports.

This patch will have to wait to be committed until Chaos tools 6.x-1.8 is released due to #866528: Ctools 1.7 breaks simple exportables

voxpelli’s picture

voxpelli commented

I want this to be committed to the Drupal 6 version prior to starting porting to Drupal 7 as it moves quite a lot of code around.

If anyone would like to roll a version without the "api" in the schema section, as mentioned in #4, I would be happy - all my time is currently going towards getting a stable version of the OAuth module released so I currently have no time to roll it myself.

Anonymous’s picture

Anonymous (not verified) commented

I've finished this work. https://github.com/voxpelli/drupal-oembed/pull/5

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Fixed

http://drupalcode.org/project/oembed.git/commit/f9536b0

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.