Defining custom operations in theme_webform_results_submissions function from a module

I think this would be a great idea. The most common way is to have the options for edit/delete/print/view/etc. as actual elements in the form with #type == 'markup'. Then we can print out any operations for each item directly in the theme function. So basically move the logic from the theme function into the building of the form instead.

Oh dear, you're quite correct. I don't know what I was thinking. Perhaps we can build this out as a renderable (a la Drupal 7), which is essentially the same thing as a form and put in our own alter hook to change it. So essentially we build it as a form and then render it as a form in the theme function. Considering this is the way Drupal 7 works with just about everything, it could be a good way to get Webform more in-line with Drupal 7's approaches anyway. Of course we'd make this change in the 6 version too.

Thanks, this patch looks like a great start. Isn't a drupal_alter() call necessary in order for other modules to add their own actions?

Works for me. I've committed your patch with a few minor changes. If you're using this patch in production, the most important change here is that I've used $table['#rows'] instead of $table['rows'], for better compatibility with Drupal 7. So in webform-results-submissions.tpl.php we have the following:

D6:

  <?php print theme('table', $table['#header'], $table['#rows']); ?>

D7:

  <?php print render($table); ?>

Other than that, changes are just cosmetic. Attached are the committed versions for D6 and D7. Thanks for the patch!

I found a bug in the D6 version that would cause all submission listings to show as empty. This patch fixes that one problem (caused by my changing 'rows' into '#rows').