Closed (fixed)
Project:
Case Tracker Due Date
Version:
6.x-1.0-alpha1
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
25 Aug 2010 at 14:44 UTC
Updated:
16 Oct 2010 at 01:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
bryan kennedy commentedI can confirm this same behavior. Interestingly, even though the case tracker content types disappear from the admin content type menu, all the case tracker content is still there in all my groups. They don't have the due date field, but they didn't disappear with the loss of the content type.
Comment #2
bryan kennedy commentedI edited the .info file for the case tracker due date feature to not require the case_tracker_basic module and the content types don't disappear. However, as soon as I enable the casetracker_basic module they disappear. When I disable it again, they come back. I know this isn't much insight, but I just wanted to share as I try and dig into the issue.
I'm not fully sure of how the atrium_casetracker, casetracker, and casetracker_basic module relate.
Comment #3
Anonymous (not verified) commentedThanks for the reports!
I am excited that beta8 is available. It was hard to track head with so many huge changes going on.
I'll get to work on this in the near future. Please report any more details you are able to track down.
Comment #4
Anonymous (not verified) commentedI'm working on tracking this down.
It seems to be an issue that happens when the module is first installed, because disabling and even removing the module doesn't cause the errors to go away.
I'm using the demo module to take snapshots of the DB and revert to them on a clean atrium-beta8 install. If anyone else has time to help debug this issue, I suggest using that technique.
Comment #5
bryan kennedy commentedI've been able to get it 90% working, by disabling parts of the functions in the install of the module. It's weird. When it boils down to it "I think" it has something to do with the alter to the calendar view. The alter seems to need it's own argument for the due date type, rather than having the due date type being included in the argument for the event types. Getting close to a patch...
Comment #6
bryan kennedy commentedPatch
OK here's a patch that worked for me to fix the problem. Please review and test it out on your install. Just to be clear, I am using this on Open Atrium specifically. I'm not entirely sure if people are using this without Open Atrium...maybe I'm assuming too much there.
What I did:
Upgrade path
What I did to test
Whitespace
When I made the patch I told the diff to ignore the whitespace. There are lots of stray whitespace endings in the module file. It'd be good to clean those out, but I didn't want to confuse this patch with that extra stuff.
Hope this works for others as well.
Comment #7
knarzer77 commentedHello,
I tried the patch and it works. But I have another problem: I have entered a task with dates from 01.07.2010 to 31.07.2010. But in the calendar the case is shown form 30.06.2010 to 30.07.2010 (see attachement).
Jan
Comment #8
bryan kennedy commentedThat's interesting. The case content type shouldn't have a from and to due date. It just has a single date value. Right?
Comment #9
Anonymous (not verified) commented@knarzer77 - Can you please open a new issue to describe that problem? It doesn't relate to this issue.
@bryan - I will be testing the patch soon. It looks great at first glance, though. Thanks so much for your help tracking this down!
Comment #10
bryan kennedy commentedI think knarzer77 actually found a bug in this patch. I've got the granularity for the due date field settings including the hours, min, and sec. The default format in the view is also wrong. So I'm working on a 2nd patch that I'll upload here in a little bit.
Comment #11
Anonymous (not verified) commented@bryan kennedy - Thanks. Looking forward to it.
Comment #12
Anonymous (not verified) commented@bryan - Are you still working on the patch? I was hoping to fix this bug up tomorrow. If you're busy with other stuff, no worries. Just wanted to check in. Thanks!
Comment #13
langworthy commentedPatch in #6 re-rolled so it applies cleanly for contrib (and can be included in a make file).
Comment #14
langworthy commentedI don't see where a to date is part of the casetracker_duedate functionality referenced in #7. I only see a single date field.
Comment #15
langworthy commentedIt seems that some versions of drush don't like patch files with spaces in them. sorry for so many posts in here with essentially the same patch.
Comment #16
Anonymous (not verified) commented@langworthy - First off, thank you so much for your work on this patch. I apologize for not being more responsive. I'm at Pacific Northwest Drupal Summit now and I'm going to get your work committed. :)
The patch works great! That's awesome.
Only one question before I commit it: What is the reasoning behind removing the casetracker_basic dependency? The view and the due date field both depend on that module.
As soon as we have that question resolved, I'll commit it.
Thanks again!
Comment #17
Anonymous (not verified) commentedSorry. My bad. I didn't realize bryan added the original patch. I should be asking him about the decision to remove casetracker_basic.
I'm going to re-add the casetracker_basic dependency then commit. If there's an argument for removing casetracker_basic, then please re-open this issue.
Thanks!
Comment #18
langworthy commentedjust to clear up all I did was re-roll so that the file paths in the patch were correct.
Comment #19
Anonymous (not verified) commentedCommitted and closed! Thanks all!
http://drupal.org/cvs?commit=430720
PS - I also changed the format from "default" to "day"
Comment #20
Anonymous (not verified) commentedAH HA! I discovered why Bryan removed the dependency on casetracker_basic.
Open Atrium basically forks casetrakcer_basic in their atrium_casetracker feature. If you have them both enabled, the delcare a lot of the same stuff and that causes most of the error messages.
So, to make this module compatible with OA and non-OA casetracker, we have to remove the explicit dependency on casetracker and rely on an implicit dependency. People will need to read the homepage or the readme to realize that they need one or the other (BUT NOT BOTH) installed.
http://drupal.org/cvs?commit=430742 removes the dependency
I'll update the readme in a moment.