Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
attached patch updates the module to 5.0. couple of things:
- i moved the settings page to admin/user/roleassign, and lower-cased the title--this seemed to fit better with the new administration layout
- i added a .info and .install file, which i'll attach in a minute here. the .install file isn't really necessary, but i threw it in with a hook_uninstall which would remove the roleassign variable from the variables table if the module is uninstalled.
- the link to the help page from the settings page wasn't working properly for sites that aren't at the web root. proper usage of l() seems to have remedied that issue. you may want to backport that fix.
- patch also removes unnecesary whitespace
Comment | File | Size | Author |
---|---|---|---|
#2 | roleassign.install | 139 bytes | hunmonk |
#1 | roleassign.info | 104 bytes | hunmonk |
roleassign_0.patch | 5.25 KB | hunmonk | |
Comments
Comment #1
hunmonk CreditAttribution: hunmonk commented.info file...
Comment #2
hunmonk CreditAttribution: hunmonk commented.install file...
Comment #3
hunmonk CreditAttribution: hunmonk commentedbtw, the patch has been tested on current HEAD and the module appears to be functioning perfectly.
Comment #4
TBarregren CreditAttribution: TBarregren commentedThanks hunmonk! The patch was great.
I have commited the patched file to HEAD. I have also updated the documentation and add some other minor improvements. So checkout the latest version from the repository.
Comment #5
acIs this going to get into core? It should be in there IMO. Is it just a matter of getting enough support or is it too late to squeeze it into 5.0?
Comment #6
TBarregren CreditAttribution: TBarregren commentedI see the point to incorporate this kind of functionality with the User module. I will raise the question on the developer mailing list to see if there is support for the idea.
Comment #7
hunmonk CreditAttribution: hunmonk commentedthis will not go into 5.0--we are in an API freeze. better lobby for the next version--i'd like to see it in there... :)
Comment #8
TBarregren CreditAttribution: TBarregren commentedYou are of course right about the code freeze.
But I have thrown out a feeler on the developer mailing list to see if there is support for incorporating RoleAssign functionality in a future version of Drupal. The responses can be found here.
Comment #9
(not verified) CreditAttribution: commented