Mobile device detection and panels [#893378]

I think this is a bug.

The panel variant that I use for mobile sites is still being used even with ?nomobile=true (although the correct desktop theme *is* being used). I can add another selection rule to get around this:
return (!$_GET['nomobile']); and all works fine, the true desktop version is shown.

So, to duplicate:
1. Create a mobile theme
2. Set up mobile tools to redirect to domain.com/mobile and to use mobile theme
3. Create Home Page panels variant with selection rule "Mobile Tools" and select all devices
- make sure variant content is actually different from desktop version
4. In mobile device, visit domain.com/mobile?nomobile=true
This results, for me, in the desktop theme being used but still using the mobile Home Page variant. Adding the above referenced additional selection rule bypasses this.

If this truly is a bug, I'd be glad to look into a fix. If not, can someone tell me what I'm doing wrong?

Panels 6.x-3.3

Comment	File	Size	Author
#5	mobile_tools.ctools_device_detection-893378-5.patch	545 bytes	klaasvw

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

chrisrockwell CreditAttribution: chrisrockwell commented 25 August 2010 at 20:11

Component:

Miscellaneous

» Code

The workaround I posted above does not solve the problem. With the workaround, exiting and returning to the panel variant controlled page results in the incorrect variant displaying (because $_GET['nomobile'] no longer exists).

The fix that I have now implemented that seems to completely solve the issue is adding the following to line 57 of mobile_tools/plugins/access/is_mobile.inc

  $mobile_session = $_SESSION['mobile-tools-site-type'];
    if ($mobile_session == 'desktop') {
      return FALSE;
    }

Comment #2

chrisrockwell CreditAttribution: chrisrockwell commented 26 August 2010 at 14:31

I'm not familiar with cvs, but I'll try to submit a patch shortly.

Comment #3

chrisrockwell CreditAttribution: chrisrockwell commented 26 August 2010 at 21:06

Status:

Active

» Needs review

Comment #4

minorOffense CreditAttribution: minorOffense commented 14 October 2011 at 22:08

Status:

Needs review

» Postponed (maintainer needs more info)

Is this still an issue? If so do you have a patch available?

Comment #5

klaasvw CreditAttribution: klaasvw commented 30 October 2011 at 13:53

Version:	6.x-1.x-dev	» 6.x-2.x-dev
Status:	Postponed (maintainer needs more info)	» Needs review

File	Size
mobile_tools.ctools_device_detection-893378-5.patch	545 bytes

This is still an issue. The ctools plugin filters by real device and doesn't take the cookie or $_GET['device'] variable into account. So that means forced switching doesn't work for the ctools access plugin.

Here's a patch against the latest 6.x dev version. It uses mobile_tools_get_device() to check the device type instead of mobile_tools_is_mobile_device()