Loading admin/build/toolbar causes the following error:

Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of toolbar_edit_form_submit(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in [...]/toolbar/toolbar.admin.inc on line 366

* Drupal 6.17
* Apache/2.2.14 (Unix)
* PHP 5.2.12

Solution:

change line 366 from 

toolbar_edit_form_submit(&$form, &$form_state);

to 

toolbar_edit_form_submit($form, $form_state);

Comments

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Active » Needs review

forgot to change state. Also, dunno if this has already been fixed in dev, its a minor bug fix in a stable release, so hopefully you can get it in for a new stable release soon.

dankh’s picture

dankh commented
Status: Needs review » Postponed (maintainer needs more info)

I can't reproduce this issue on multiple hosts. Pass by reference in function definition is ok what is actually deprecated is to call the function with referenced variable (http://www.php.net/manual/en/language.references.pass.php). In toolbar_edit_form_submit() there are no calls with reference.

Also consider upgrading to Drupal 6.19 due to http://drupal.org/node/360605 .

lpalgarvio’s picture

lpalgarvio commented

regarding my previous issue (duplicate):
PHP 5.2.14
Drupal 6.19

dankh’s picture

dankh commented
Assigned: Unassigned » dankh
Priority: Normal » Major
Status: Postponed (maintainer needs more info) » Active

Bug confirmed. Thanks both of you for the report.

dankh’s picture

dankh commented
Status: Active » Fixed

Fix committed in 6.x-2.x-dev . Release will follow.

http://drupal.org/cvs?commit=418392

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.