Closed (fixed)
Project:
FFmpeg Converter
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
26 Aug 2010 at 09:05 UTC
Updated:
19 Sep 2010 at 18:00 UTC
Jump to comment: Most recent file
This patch basically rips out the preset admin code and instead implements export_ui in Ctools. The result is about 470 deleted and 180 added lines of code:
$ grep -c "^\-" ffmpeg_converter_export_ui.patch
471
$ grep -c "^\+" ffmpeg_converter_export_ui.patch
183
It seems to work fine, but testers and reviewers are warmly welcome. I'll probably commit this very soon in order to reach more testers through the -dev version.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | ffmpeg_converter_export_ui-3.patch | 27.48 KB | zoo33 |
| #4 | ffmpeg_converter_export_ui-2.patch | 23.9 KB | zoo33 |
| #1 | ffmpeg_converter_export_ui.patch | 24.61 KB | zoo33 |
Comments
Comment #1
zoo33 commentedAargh, the patch file!
Comment #2
zoo33 commented...and the status.
Comment #3
amitaibuI think this code if exists, should move to CTools itself. Other stuff from a quick eye-review look ok, but not really tested.
Powered by Dreditor.
Comment #4
zoo33 commentedMaybe those lines weren't actually that useful in the first place. You can clearly see the status of each preset on the overview page, so I don't think you need to be reminded of that on each editing form.
Attaching a new version of the patch.
Comment #5
zoo33 commentedHere's another version where I've cleaned up some of the code that loads presets. I now tap into Ctools' load mechanism in order to be able to sanitize presets before they are used anywhere.
Comment #6
zoo33 commented...aaaand the patch.
Comment #7
zoo33 commentedOh, a Varnish error there... Trying again.
Comment #8
zoo33 commentedCommitted! Thanks Amitaibu for the initial idea, the review – and the amazing presentation at Drupalcon!