Download & Extend
Issues

PHP incompatibility message is not complete

Posted by boombatower on August 26, 2010 at 9:31pm
Project:Drupal core
Version:7.x-dev
Component:system.module
Category:bug report
Priority:normal
Assigned:boombatower
Status:closed (fixed)

Issue Summary

<?php
if (substr_count($info['php'], '.') < 2) {
  $php_required .= '.*';
}
?>

$php_required is never initialized so the value is either ".*" or "" so the user message reads funny since there is an incorrect value (or none) placed in it.

Login or register to post comments

Comments

#1

Posted by boombatower on August 26, 2010 at 9:32pm
Assigned to:Anonymous» boombatower
Status:active» needs review
AttachmentSizeStatusTest resultOperations
894614-php-compatibility.patch710 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 894614-php-compatibility.patch.View details

#2

Posted by solotandem on August 26, 2010 at 10:43pm
Status:needs review» reviewed & tested by the community

Makes sense.

#3

Posted by sun on September 28, 2010 at 11:22pm

#1: 894614-php-compatibility.patch queued for re-testing.

#4

Posted by Dave Reid on September 30, 2010 at 2:51am

Marked #806312: This module requires PHP version .* and is incompatible with PHP version as a duplicate of this issue since this one is RTBC.

#5

Posted by Dries on October 3, 2010 at 12:48am
Status:reviewed & tested by the community» fixed

Good catch, boombatower. Committed to CVS HEAD. Thanks.

#6

Posted by System Message on October 17, 2010 at 12:50am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.