Input Formats breaks Admin Theme

wow... i was just going to report the same issue...

Hi, thanks for reporting this.

I saw this too a few weeks ago. It seems to be a problem with Strongarm and the 'admin_theme' variable.

Debugging a bit of code, I found the raise of the problem in the wysiwyg_filter module. Last development version of wysiwyg_filter and this patch: #887532: Follow up: Input formats integration should fix the problem (at least it worked in my case).

However, if you are not using wysiwyg_filter, I would be nice to know which filter modules are you using on your sites, maybe they have to be patched too.

In my case it's probably the wysiwyg module, i'll check, thanks.

I've tried the last dev of wysiwyg_filter and the patch, but I'm still getting the problem. In my case, every time i clear the cache, the admin theme gets ignored and the site shows the default theme for the next 1 or 2 requests (maybe a different issue?).

You have to rebuild the feature with the patch applied.

Check if your feature have the item 'wysiwyg_filter_valid_elements_parsed' => array(... ) inside

$input_format->settings['wysiwyg_filter']

If not, there is your problem.

Hi:

I really want to fix this problem, however, I cannot replicate anymore. It would help if you provide the 'export' of your input format and attach it here.

Thanks

I'm also having this problem. I'm not using the wysiwyg_filter module.

Edit: This module is also breaking context_reaction_theme module

This is what happens in my site: every time the menu is rebuilt or I flush the cache (even clearing the cached css/js), the administration theme goes back to the front theme for the next one or two page refreshes.
Note that this doesn't happen when I clear the theme registry.

Not entirely sure but think the problem is with imported input formats like the following:

$input_format = new stdClass;
$input_format->api_version = 1;
$input_format->name = 'WYSIWYG';
$input_format->roles = array(
  2 => 'authenticated user',
  3 => 'site editor',
);
$input_format->cache = TRUE;
$input_format->settings = array(
  // Settings for: pathologic module
  'pathologic' => array(
    // Also considered local
    'filter_pathologic_local_paths' => '',
    // Output full absolute URLs
    'filter_pathologic_absolute' => 1,
  ),
  // Settings for: wysiwyg_filter module
  'wysiwyg_filter' => array(
    // HTML elements and attributes
    'wysiwyg_filter_valid_elements_raw' => '@[class|style|title],
a[href|target|title|name],
img[src|width|height|alt|title],
em, strong, strike, del, sub, sup, i, b, q, acronym, samp, kbd,
ul, ol, li, dl, dt, dd,
p[align<center?justify?left?right], br, hr,
div[align<center?justify?left?right], span,
table[width|cellpadding|cellspacing|border], tr[align|valign], td[align|valign|width], tbody, th[align|valign|width], thead, tfoot, colgroup, col, caption,
address, blockquote, pre, cite, code,
h1, h2, h3, h4, h5, h6',
    // HTML comments
    'wysiwyg_filter_allow_comments' => 's:1:"0";',
    // Color and background properties
    'wysiwyg_filter_styles_color' => array(
        'color' => 0,
        'background' => 0,
        'background-color' => 0,
        'background-image' => 0,
        'background-repeat' => 0,
        'background-attachment' => 0,
        'background-position' => 0,
      ),
    // Font properties
    'wysiwyg_filter_styles_font' => array(
        'font-style' => 'font-style',
        'font-weight' => 'font-weight',
        'font' => 0,
        'font-family' => 0,
        'font-size' => 0,
        'font-size-adjust' => 0,
        'font-stretch' => 0,
        'font-variant' => 0,
      ),
    // Text properties
    'wysiwyg_filter_styles_text' => array(
        'text-align' => 'text-align',
        'text-decoration' => 'text-decoration',
        'text-indent' => 0,
        'text-transform' => 0,
        'letter-spacing' => 0,
        'word-spacing' => 0,
        'white-space' => 0,
        'direction' => 0,
        'unicode-bidi' => 0,
      ),
    // Box properties
    'wysiwyg_filter_styles_box' => array(
        'margin' => 'margin',
        'padding' => 'padding',
        'margin-top' => 0,
        'margin-right' => 0,
        'margin-bottom' => 0,
        'margin-left' => 0,
        'padding-top' => 0,
        'padding-right' => 0,
        'padding-bottom' => 0,
        'padding-left' => 0,
      ),
    // Border properties (1)
    'wysiwyg_filter_styles_border-1' => array(
        'border' => 'border',
        'border-top' => 0,
        'border-right' => 0,
        'border-bottom' => 0,
        'border-left' => 0,
        'border-width' => 0,
        'border-top-width' => 0,
        'border-right-width' => 0,
        'border-bottom-width' => 0,
        'border-left-width' => 0,
      ),
    // Border properties (2)
    'wysiwyg_filter_styles_border-2' => array(
        'border-color' => 0,
        'border-top-color' => 0,
        'border-right-color' => 0,
        'border-bottom-color' => 0,
        'border-left-color' => 0,
        'border-style' => 0,
        'border-top-style' => 0,
        'border-right-style' => 0,
        'border-bottom-style' => 0,
        'border-left-style' => 0,
      ),
    // Dimension properties
    'wysiwyg_filter_styles_dimension' => array(
        'height' => 'height',
        'width' => 'width',
        'line-height' => 0,
        'max-height' => 0,
        'max-width' => 0,
        'min-height' => 0,
        'min-width' => 0,
      ),
    // Positioning properties
    'wysiwyg_filter_styles_positioning' => array(
        'bottom' => 0,
        'clip' => 0,
        'left' => 0,
        'overflow' => 0,
        'right' => 0,
        'top' => 0,
        'vertical-align' => 0,
        'z-index' => 0,
      ),
    // Layout properties
    'wysiwyg_filter_styles_layout' => array(
        'clear' => 'clear',
        'float' => 'float',
        'display' => 0,
        'position' => 0,
        'visibility' => 0,
      ),
    // List properties
    'wysiwyg_filter_styles_list' => array(
        'list-style-type' => 'list-style-type',
        'list-style' => 0,
        'list-style-image' => 0,
        'list-style-position' => 0,
      ),
    // Table properties
    'wysiwyg_filter_styles_table' => array(
        'border-collapse' => 0,
        'border-spacing' => 0,
        'caption-side' => 0,
        'empty-cells' => 0,
        'table-layout' => 0,
      ),
    // User interface properties
    'wysiwyg_filter_styles_user' => array(
        'cursor' => 0,
        'outline' => 0,
        'outline-width' => 0,
        'outline-style' => 0,
        'outline-color' => 0,
        'zoom' => 0,
      ),
    // Rules for Class Names
    'wysiwyg_filter_valid_classes' => array(
        0 => 'alternate',
      ),
    // Rules for Element IDs
    'wysiwyg_filter_valid_ids' => array(),
    // Rules for URLs used within inline styles
    'wysiwyg_filter_style_urls' => array(),
    // Policy
    'wysiwyg_filter_nofollow_policy' => 'whitelist',
    // Domains list
    'wysiwyg_filter_nofollow_domains' => array(
        0 => 'itan\\.mayhem',
      ),
    // Valid elements parsed
    'wysiwyg_filter_valid_elements_parsed' => array(
        'a' => array(
          'href' => array(),
          'target' => array(),
          'title' => array(),
          'name' => array(),
          'class' => array(),
          'style' => array(),
        ),
        'acronym' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'address' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'b' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'blockquote' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'br' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'caption' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'cite' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'code' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'col' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'colgroup' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'dd' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'del' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'div' => array(
          'align' => array(
            'values' => array(
              0 => 'center',
              1 => 'justify',
              2 => 'left',
              3 => 'right',
            ),
          ),
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'dl' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'dt' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'em' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'h1' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'h2' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'h3' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'h4' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'h5' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'h6' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'hr' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'i' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'img' => array(
          'src' => array(),
          'width' => array(),
          'height' => array(),
          'alt' => array(),
          'title' => array(),
          'class' => array(),
          'style' => array(),
        ),
        'kbd' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'li' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'ol' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'p' => array(
          'align' => array(
            'values' => array(
              0 => 'center',
              1 => 'justify',
              2 => 'left',
              3 => 'right',
            ),
          ),
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'pre' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'q' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'samp' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'span' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'strike' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'strong' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'sub' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'sup' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'table' => array(
          'width' => array(),
          'cellpadding' => array(),
          'cellspacing' => array(),
          'border' => array(),
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'tbody' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'td' => array(
          'align' => array(),
          'valign' => array(),
          'width' => array(),
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'tfoot' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'th' => array(
          'align' => array(),
          'valign' => array(),
          'width' => array(),
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'thead' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'tr' => array(
          'align' => array(),
          'valign' => array(),
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
        'ul' => array(
          'class' => array(),
          'style' => array(),
          'title' => array(),
        ),
      ),
  ),
  // Settings for: invisimail module
  'invisimail' => array(
    // JavaScript
    'invisimail_js' => '1',
    // Auto-link Emails
    'invisimail_link' => '1',
  ),
);
$input_format->filters = array(
  'filter' => array(
    // Delta => Weight for: Line break converter
    '1' => '-10',
    // Delta => Weight for: HTML corrector
    '3' => '-8',
  ),
  'pathologic' => array(
    // Delta => Weight for: Pathologic
    '0' => '-7',
  ),
  'wysiwyg_filter' => array(
    // Delta => Weight for: WYSIWYG Filter
    '0' => '-6',
  ),
  'invisimail' => array(
    // Delta => Weight for: Encode email addresses
    '0' => '-5',
  ),
);
$input_format->machine = 'wysiwyg';

subscribing

Subscribing And a +1 for the breakage.

Not yet even using the module, just installed it and my administration theme went away.

And I have the admin_theme variable already strongarmed, hmm.

Subscribing. We have wysiwyg installed, but now wysiwyg_filter and see this problem on almost every page load.

We are still seeing this error:

wysiwyg = installed
wysiwyg_filter = not installed
htmlpurifier = installed

admin theme = rubik

more data: with this module enabled, the theme_init() function fires off BEFORE system_init() ... this is the cause of the admin theme breaking.

It seems that the strongarm module purposely gives itself a very negative weight in the system table and so its hook_init gets called *before* system_init(). Normally this isnt a problem, but somewhere in inputformats strongarm is being used in a way such that some value is buried inside a t(). This call to t() calles theme() which in turn calls theme_init().

I *think* this may be a core bug (theme_init() should check for admin theme)

Stil investigating...

found the related bug report: #219910: Calling theme function from hook_init() interferes with administration theme

the attached patch is a bandaid solution. It works (in a non-destructive way) by calling system_init() from within strongarm_init(). This is not an ideal solution, but it works and wont break anything. It doesnt make sense to open an issue for strongarm because the real problem is in core.

BLAAAAAAARGG!

bleen18, if your patch is against strongarm it should be posted against their issue queue. Just saying. But you did say it is a bandaid, so maybe you don't intend on them ever "fixing" the issue within strongarm, and rather there should be a better solution.

nicholas.alipaz: The patch in #19 is not something I would expect the strongarm maintainers to consider including. It isn't really "correct" ... I do hope there is a better fix out there, but in the mean time I wanted to offer those stricken by this issue have a workable fix.

Thanks for the clarification bleen18. I hope it gets fixed. This and the need to use wysiwyg filter for input formats has made me resolve to uninstall the input formats module from my features. I will keep following the queue in hopes that I can eventually place input formats in code. Otherwise I will just strongarm wysiwyg filter and leave input formats alone if the module never gets more stable.

not sure if i should open a separate issue thread, but this isnt just an issue with the ADMIN THEME. input formats killed PAGE THEME in my case. so the problem must be with the theme switching function.

subscribing- just spend a week developing a fully working WYSIWYG feature which we've just rolled out and now are experiencing lots of theme problems.
templates aren't being read unless flushing the cache.

Has this been posted over in the strongarm issue queue??? I can confirm that the patch fixed my issue

"bandaid" patch #19 applied and seems to work. Thanks.

Issue #219910 has been there since 2008 so I wouldn't assume this is going to get fixed soon.

Also this comment: http://drupal.org/node/219910#comment-4559682 seems that coul help to solve this in a more ellegant way:

Another way to circumvent HOOK_init() is this:

function HOOK_theme_registry_alter(&$theme_registry) {
  array_unshift($theme_registry['page']['preprocess functions'], 'your_hook_init_function');
}

This way you can safely call theme() functions from your init function without any problems.
I found this solution at http://drupal.org/node/599106 and it really works.

PS: There is no issue filled in Strongarm. should I move this issue over there ?
Cheers.

re #25... I refer you to #21. This really isn't an issue with strongarm, its a problem with core