Need to crib from node_type_form_validate() so changes of type machine name are handled.

Comments

fago’s picture

field API changes should already be fine thanks to the CRUD api, however we need to prevent duplicates + enforce no special characters are used.

fago’s picture

Status: Active » Fixed

thanks to the new machine name element, this should be fine now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

reptilex’s picture

Status: Closed (fixed) » Needs review

Thanks for the work on the module.

I installed the latest version available today (7 Jan 2011). Set up a few fields, than tried to change the machine name, my fields disappeared and I had a Notice:

"Notice: Undefined index: mainprofil in _field_ui_bundle_admin_path() (line 310 of /Library/WebServer/Documents/nefia7/modules/field_ui/field_ui.module)."

When I changed it back again, my fields reapeared but I have a similar notice:

"Notice: Undefined index: main in _field_ui_bundle_admin_path() (line 310 of /Library/WebServer/Documents/nefia7/modules/field_ui/field_ui.module)."

This is hardly the expected behaviour, or is this a "feature"? ;). Maybe it is an underlying problem in core, I think I have not done a machine name change before.

Sidenote/question, you don't happen to know how I could add separators between the fields, do you?

fago’s picture

Status: Needs review » Fixed

thanks, indeed this was broken. There was a bug in the entity API causing this, please update the entity API to the next dev snapshot - then it should work.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.