The Style options OpenLayers Data views allow to choose several Map Sources at once (like Lat/Lon point and WTK at the same time), but it then misses the fields specify where this data should come from.
As discussed during the Documentation sprint in Copenhagen: this should probably be radio buttons instead, with the description text referring not referring to sources in plural either.

CommentFileSizeAuthor
#3 data_source_value.patch853 bytesstrk

Comments

zzolo’s picture

zzolo commented
Version: 6.x-2.0-alpha8 » 6.x-2.x-dev

Thanks for the notification on this. I think the original idea was to support multiple data sources in one data overlay, but interface-wise and code-wise, it does not seem like it would be worth the trouble, since it has not been a requested feature or even noticed until now.

tmcw’s picture

tmcw commented
Status: Active » Fixed

Fixed: http://drupal.org/cvs?commit=416648

strk’s picture

strk commented
Status: Fixed » Needs review
StatusFileSize
new data_source_value.patch853 bytes

In commit 416648 you changed too much code, it seems. Even if non-multiple the checkbox values retain the structure they had before, that is "key" => "key" when selected. At least this is what happens here.

Did you try re-saving an old view recently ?
The attached patch fixes the problem for me (one line).

strk’s picture

strk commented
Status: Needs review » Fixed

After updating the "data" display style (engine icon) and "save" ing the view again, code in HEAD is fine to handle it, while my patch clearly isn't. So no problem with HEAD except some care is required for upgrade paths.

zzolo’s picture

zzolo commented
Status: Fixed » Needs review

It sounds like this should be reviewed for upgrade path? I'll try to check out tonight.

Status: Needs review » Needs work

The last submitted patch, data_source_value.patch, failed testing.

zzolo’s picture

zzolo commented
Status: Needs work » Fixed

Good catch, @strk. Included groups as well and committed:
http://drupal.org/cvs?commit=420186

tmcw’s picture

tmcw commented
Status: Fixed » Active

Wait, why is this being addressed with backwards compatibility rather than an update hook? Wouldn't the latter be a better long-term solution?

tmcw’s picture

tmcw commented

In fact, the approach taken here has broken openlayers data views for alpha 9. zzolo: revert, fix, re-release.

tmcw’s picture

tmcw commented

Reverted: http://drupal.org/cvs?commit=420440

zzolo’s picture

zzolo commented
Title: Style options allow to choose several Map Data sources » Style options allow to choose several Map Data sources (create update function)

I totally agree that this was not the most ideal solution, and that an update would be more appropriate, but due to the the complexity of the update, I figured this would be a little more stable fix. An update function can be addressed for next release.

As for now, I have put in a fix that addresses new code and is backwards compatible. Just wanted to get a new release out before people started upgrading. I know it is not ideal.

My apologies for not testing as best as I could. @tmcw, your code did not address people upgrading, and I thought @strk's patch addressed the new code.

Keeping open for update functionality.

zzolo’s picture

zzolo commented
Status: Active » Fixed

So, an update hook would not address any Views that are in code, which means we would still need to have the backwards compatible code. Also, this is kind of low priority. I am gonna close, but if anyone wants to work on the upgrade path, please go re-open as needed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.