The attached patches implement the following changes:

- A new action, "Change workflow state of a node to any state", that let's a workflow transition itself to any other state.

- The Add Actions drop-down list is now categorized by type so it is much easier to read and use.

- _workflow_node_to_state now updates the $node->workflow and ->_workflow fields so any other code that uses them in the same request will see the correct value.

- _workflow_write_history attempts to make multiple log entries made during the same request show up in the correct order.

Thanks,

Barry

CommentFileSizeAuthor
#2 patch_1536.04 KBmoshe weitzman
workflow-patch.txt6.19 KBbjaspan

Comments

bjaspan’s picture

bjaspan commented

These patches were sponsored by WheresSpot, Inc., http://www.wheresspot.com.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new patch_1536.04 KB

finally tested this (and scheduled actions module). works real well.

just some code style nits:

- make this text more generic: "Payment will only be captured if the node has at least one of the terms selected."
- always use curly braces for an if statement - even 1 liner
- indentation

mfredrickson’s picture

mfredrickson commented

I've committed the change to the action listing sections.

The patch didn't cleanly apply, and I'm unsure if any changes need to be made to the body of workflow code to support the change to any state action.

Can you reroll to current 4.7-1.x-dev? Also, if you could split it into multiple patches: one for each change, or at least one for the action and one for the bug fixes, I would greatly appeciate it.

Thanks!

-Mark

moshe weitzman’s picture

moshe weitzman commented
Status: Reviewed & tested by the community » Needs work

barry is presenting about this now. lets send him this reminder email that this issue needs work.

Bastlynn’s picture

Bastlynn commented
Status: Needs work » Closed (won't fix)

Hi,

This ticket was last updated over 4 years ago, and hasn't seen additional work since then. Based on that, and that development is now progressing on Drupal 7, I'm going to go ahead and close this one out. If you would still like to see this feature, please post a request for Drupal 7, then we can work on the Drupal 6 version.

- Bastlynn