Posted by bdillahu on October 16, 2006 at 8:14pm
| Project: | Amazon associate tools |
| Version: | 5.x-1.5 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The latest version has a missing "span" and is still missing (in my opinion) a
to make the line breaks look right... here's a diff on amazon.module that I think fixes it. Thanks!!!
| Attachment | Size |
|---|---|
| diff_4.txt | 286 bytes |
Comments
#1
It would help if this bug were assigned to the correct project
#2
#3
Ok, after looking at this, I came to the following conclusions:
1. The patch is in non-unified format (which is bad)
2. The "span" problem has already been fixed in head
3. The line break problem is now amazingly simple. Patch attached, but it's barely necessary.
#4
I am consolidating the patches for this and will either submit it and get the original author to post it as a dev version, or I will fork it (not what I want).
Im questioning, if you want a
added then why is it a span and not a div?
#5
I see, fixed...
#6
The patch is applied to http://drupal.org/node/289780#comment-945539
#7
fixed, should be in dev
#8
oops
#9
Automatically closed -- issue fixed for two weeks with no activity.