formatting in block wrong

bdillahu - October 16, 2006 - 20:14
Project:Amazon associate tools
Version:5.x-1.5
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

The latest version has a missing "span" and is still missing (in my opinion) a
to make the line breaks look right... here's a diff on amazon.module that I think fixes it. Thanks!!!

AttachmentSize
diff_4.txt286 bytes

#1

wayland76 - February 9, 2008 - 03:43
Project:Amazon Filter» Amazon associate tools
Version:4.7.x-1.x-dev» 4.7.x-1.x-dev

It would help if this bug were assigned to the correct project

#2

wayland76 - February 9, 2008 - 03:45
Version:4.7.x-1.x-dev» 5.x-1.5

#3

wayland76 - February 14, 2008 - 01:51
Status:active» needs review

Ok, after looking at this, I came to the following conclusions:
1. The patch is in non-unified format (which is bad)
2. The "span" problem has already been fixed in head
3. The line break problem is now amazingly simple. Patch attached, but it's barely necessary.

AttachmentSize
amazontools_fix_linebreak.patch 831 bytes

#4

MGParisi - July 31, 2008 - 23:01

I am consolidating the patches for this and will either submit it and get the original author to post it as a dev version, or I will fork it (not what I want).

Im questioning, if you want a
added then why is it a span and not a div?

#5

MGParisi - July 31, 2008 - 23:04

I see, fixed...

#6

MGParisi - August 1, 2008 - 00:52

#7

MGParisi - September 17, 2008 - 20:50

fixed, should be in dev

#8

MGParisi - September 17, 2008 - 20:50
Status:needs review» fixed

oops

#9

Anonymous (not verified) - October 1, 2008 - 20:52
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.