Alert unpublishes every time cron is run

My time limit is 24 hours. We are still in the development stage so we're running cron a lot and clearing the cache a lot, but the unpublishing seems rather random. I can't even really say it is happening every time cron is run but it has certainly consistently unpublished before the 24 hour limit. I'll publish a few more today and see what happens. Hopefully I can find out a little more information for you.

I've narrowed down what's causing this (for us at least). Any time any content is added or updated on the site, the user alert seems to be unpublished. I think user_alert_nodeapi fires every time any node is updated or inserted. So there should be a check in there for the node type user_alert. The following code seems to work for me.

function user_alert_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {
	switch ($op) {
		case 'insert':
		case 'update':
		  if ($node->type == 'user_alert') {
  			$result = db_query('SELECT nid, status FROM {node} WHERE type = "%s" AND nid != %d', 'user_alert', $node->nid);
  			while ($row = db_fetch_object($result)) {
  				db_query('UPDATE {node} SET status = %d WHERE status = %d AND nid = %d', 0, 1, $row->nid);
  			}
		  }
		break;
	      default:
		break;
	}
}

Awesome, sounds great.

However, I downloaded 1.3 and this doesn't seem to have made it in.

No problem, I think you're doing great. I don't have much experience with CVS either so I can't say I'd be doing much better.