Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I know my drupal is a little old (4.5.8-5 in Debian), but this problem existed in the last version (though I don't remember precisely what that was) and seems to even be in the current CVS version.
The regular expressions in _filter_autop() seem to be broken. Comments simply do not appear in any views with any skins with my installation (and I resinstalled, and I don't customize it). Throwing in some diagnostics revealed that the comment text _is_ there up until check_output() is called, at which point it disappears when the set of regular expressions are run over it. These are normal text comments in English with no strange characters. For example, the comment "test" is eliminated.
To "fix" this, I have simply commented out the two offending regular expressions. It's not at _all_ clear what they are trying to do (add some whitespace to the HTML?!). Anyway, I've attached a very simple diff that just disables the two offending lines.
For now, I am patching this by hand. Let me know if I can do any further investigations to help. Thanks.
| Comment | File | Size | Author |
|---|---|---|---|
| foo.diff | 1017 bytes | Brad Spencer |
Comments
Comment #1
killes@www.drop.org commentedDrupal 4.5 is no longer supported by us.
Comment #2
Brad Spencer commentedSure. I'm not actually looking for any support; I can fix my installations using the outdated packages without much of an issue. I have three suggestions in that case:
1. Remove the Drupal 4.5.x cases from the dropdown box for filing bugs. (Or leave it and display a message to that effect when someone picks one.)
2. In my report, I noted that the same regular expressions are still on the trunk. If there is truly something wrong, then it may still happen there under whatever the circumstances are (obviously comments were not "just plain broken" in 4.5 or you would have closed this as "fixed" instead of "wontfix".
3. Perhaps a question to the Debian package maintainer is in order? Would you like me to file a Debian bug report about it to get his or her attention (even for these older versions). I am using Debian unstable, so you might be interested in checking with the Debian drupal maintainer to see why they are using such old packages in a distribution intended to try out newer packages.
Thanks!