hey
just wanted to contribute a mini patch to the javascript/jQuery that smooths out the mouseover/mouseout actions of the [Edit] link on Click to Edit display style. It basically utilizes hover() and queue(), the latter being in jQuery 1.2 so it should be fine for stock drupal jQuery but i just realized i didnt test stock jQuery... if anyone's willing to confirm that this works without jquery_update and smooths out the [Edit] appearance that would be great.
thanks
| Comment | File | Size | Author |
|---|---|---|---|
| editablefields.js_.hover_.patch | 1.01 KB | vishun |
Comments
Comment #1
vishun commentedJust wanted to note that not only does this work with the stock jQuery, but it also appears to increase client side performance. I was having an issue where a large arrangement of views with Click to Edit fields was causing slow script warnings on Firefox and this patch resolved those warnings.
It's likely that this can still be improved some.
Comment #2
mattew commentedHi,
Thanks for this module, wich is very usefull.
But if i could give a piece of advice. Maybe you should remove mouseover, mouseout and all other events from your module and just rely on CSS hover to deal with your "edit" link visibility.
Because trying to change the "hover" behaviors is impossible without modifying directly the module (and it's bad ;-). We can't do anything to change the hover effect, and that despite of all, it doesn't works very well because effects aren't stopped (so links are blinking).
And to give us possibility to bind events like you at the callback of ajax calls, just provide a custom callback or custom events.
I can participate to this improvement if you don't know how to do.
Best regards,
Comment #3
vishun commentedYeah, not a bad idea. The only thing about a CSS approach is it doesn't do fading in and out like the present jQuery does, but if you have ideas on how to improve this in general, by all means post a patch for review.
Comment #4
kenorb commentedClosed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.