I made the following fixes:

  • Changed the admin/user/notify page to show/edit all (enabled) users.
  • Fixed theming admin/user/notify
  • Moved and renamed "my notifications" to "my account -> email notification"
  • Fixed "notifications" link in "admin -> accounts"

    Also included the fixes by Capnj here:
    http://drupal.org/node/view/7166#comment-7892

    Point is, I have no idea how to make a patch out of this, so I can only post the fully patched module for now. Hope I'm not breaking any rules by doing so (but thought my changes might come in handy).

CommentFileSizeAuthor
#10 drupal-4-4.junyor.notify.patch9.15 KBjunyor
#5 notify_3.patch6.58 KBBèr Kessels
#1 notify_2.patch6.58 KBBèr Kessels
notify.module11.17 KBahoeben

Comments

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new notify_2.patch6.58 KB

I did not test it, nor checked the new modules validity. I only made the module you posted into a patch. That makes it much easier for dvelopers to work.

junyor’s picture

junyor commented

Do these same problems affect the CVS version?

It's actually pretty simple to make a patch. See details at http://drupal.org/book/view/325 and http://drupal.org/book/view/323. If you're using Windows, I recommend TortoiseCVS (http://www.tortoisecvs.org/).

ahoeben’s picture

ahoeben commented

Ber, thanks for making that patch (though it seems to me this is patching the wrong way around, from my patched version back to 4.4.0)

Junyor, thanks for the TurtoiseCVS link. I'll try to learn how to make my own patches now (and perhaps more...)

As for the CVS version. I started my version from the one available here:
http://drupal.org/files/projects/notify-cvs.tar.gz

After I uploaded my version I found out there's another patch (http://drupal.org/node/view/8658) that fixes the theming of the admin/user/notify page (among other things), but it doesn't seem to allow you to show/edit all users' notify settings.

ahoeben’s picture

ahoeben commented

Ber, thanks for making that patch (though it seems to me this is patching the wrong way around, from my patched version back to 4.4.0, but I'm no patching expert ;-) )

Junyor, thanks for the TurtoiseCVS link. I'll try to learn how to make my own patches now (and perhaps more...)

As for the CVS version. I started my version from the one available here:
http://drupal.org/files/projects/notify-cvs.tar.gz

After I uploaded my version I found out there's another patch (http://drupal.org/node/view/8658) that fixes the theming of the admin/user/notify page (among other things), but it doesn't seem to allow you to show/edit all users' notify settings.

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new notify_3.patch6.58 KB

Doh Doh Doh! this one's the other way around ;) I am used to making pathces via CVS, this one was patched against a local copy.

junyor’s picture

junyor commented

Sounds like the change is for CVS, then. Do we need a separate patch for the 4.4.0 branch to fix http://drupal.org/node/view/7166#comment-7892?

Anonymous’s picture

(not verified) commented

No, I patched agains 4.4 and the version was set 4.4.
ahoeben, can you please donfirm.

ahoeben’s picture

ahoeben commented

The patch is for the currently downloadable CVS version v 2.49 2004/04/09. This seems to be the exact same version that is included with the 4.4.0 archive of the notify module.

The patched module works fine in a 4.4.1 install.
Note that I did not fix anything other than the admin/user/notify page and, the menu items and the clickable patch; I didn't touch the cron job on what gets posted when.

junyor’s picture

junyor commented

Setting back to 4.4.0. There have been some changes in drupal-cvs for menus, so this patch doesn't necessarily only apply to cvs. However, that shouldn't stop this patch from making the 4.4.x branch and cvs. :)

junyor’s picture

junyor commented
StatusFileSize
new drupal-4-4.junyor.notify.patch9.15 KB

And a new patch. This patch includes:

- all previous changes
- another URL fix (from Morbus Iff's patch in http://drupal.org/node/view/8658)
- standardization of all mentions of "mail" and "email" to "e-mail"

This patch applies cleanly to the 4.4.0 and CVS releases.

junyor’s picture

junyor commented

I've put a copy of notify.module with this patch and a couple others in my sandbox.

RobRoy’s picture

RobRoy commented
Version: » master
Status: Needs review » Closed (fixed)

Closing old bugs that appear fixed.