Since this commit which removed the ability for anonymous/authenticated users to view nodes, when a site is disabled, guests get 'Access denied' viewing the 'disabled' page rather than the disabled page itself.

I can't remember why we implemented this - I enabled 'access content' for the anonymous user, which allowed me to view the Disabled page as expected. I confirmed I was still unable to access various other nodes like sites, packages, tasks etc - I suspect that these restrictions are being caught by other specific access controls per node type, which is good.

This being the case, can we re-instigate setting the 'access content' setting for the anonymous user in the hostmaster.profile?

Comments

Anonymous’s picture

Status: Active » Needs review

I think we can enable the permission 'access content' for 'anonymous users'. I don't think this privilege will expose any other nodes to anonymous users, because all other node types such as server, platform, site, package and task have their own 'view' permission that is also unchecked for anonymous users.

Unless Antoine or Adrian can see this turning into a migression, I'll be committing this, it's crazy to have a disabled disable page :)

adrian’s picture

"This being the case, can we re-instigate setting the 'access content' setting for the anonymous user in the hostmaster.profile?"

no.

this caused all kind of trouble before.

Anonymous’s picture

OK...

How about a 'view disabled sites' permission in hosting_site and change the 'access arguments' to /hosting/disabled to be 'view disabled sites' from 'access content'

Anonymous’s picture

Status: Needs review » Fixed

Thats what i ended up doing.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 1782d5b on dev-dns, dev-migrate_aliases, dev-multiserver-install, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by mig5:
    #896492 - add 'access disabled sites' permission so that the disabled...

  • Commit 1782d5b on dev-dns, dev-migrate_aliases, dev-multiserver-install, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by mig5:
    #896492 - add 'access disabled sites' permission so that the disabled...