Regression: Featured region expands to full width [#896956]

Featured region should not extend the full width.

Somewhere along the way the div.section inner was removed and the section and clearfix classes applied to the div#featured container - this is wrong because then there is no inner wrapper to contain the width (in layout.css it is set to 960px).

The patch reinstates the .section inner DIV and adjusts the padding on #featured which also looks wrong (the padding top is huge, way to big when you add the margin/padding etc applied to block content).

Comment	File	Size	Author
#7	drupal-bartik-896956-7.patch	1.31 KB	tim.plunkett
	bartik-featured-region.png	90.3 KB	Jeff Burnz
	bartik-fix-featured-region.patch	1.29 KB	Jeff Burnz

Comments

Comment #1

tim.plunkett

he/him

English

Philadelphia

commented 30 August 2010 at 18:11

Status:

Active

» Needs review

Ugh. The differences between having #main-wrapper > #main and #featured > .section and #footer-wrapper > .section > #footer are confusing and seemingly arbitrary.

That said, this patch does fix the regression, and should go through.

Comment #2

Jeff Burnz commented 30 August 2010 at 19:47

Issue tags:

+Needs design review

Agreed, the markup needs a good cleanup - there's a couple of other patches floating in the queue that try to get rid of some of the redundant section DIV's.

Needs an RTBC, maybe Jen should see it first because it adjusts the padding, which I am sure used to be more like I have it now.