Download & Extend

Testing profile skips required modules

Project:Drupal core
Version:7.x-dev
Component:install system
Category:bug report
Priority:normal
Assigned:moshe weitzman
Status:closed (duplicate)

Issue Summary

The testing profile does not enable required modules like node but uses its permission 'access content'. This leads to a fatal error during testing_install() using drush. Attached patch adds one dependencies[] line to testing.info which is enough to kick in the dependency check and thus all required modules are enabled. Patch also adds a customary files[] = testing.profile like other profiles.

AttachmentSizeStatusTest resultOperations
testing_profile.patch699 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 23,318 pass(es).View details | Re-test

Comments

#1

Status:needs review» needs work

I don't see that second hunk as mentioned in this patch.

#2

Status:needs work» needs review

woops. posted wrong patch. this one adds the single required line. the files[] entry is kinda pointless as long as testing.profile is empty.

AttachmentSizeStatusTest resultOperations
testing.patch456 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 23,325 pass(es).View details | Re-test

#3

I guess this profile is a bit of an edge case, but seems like a bug in the installer itself if it ever allows Drupal to be installed without the required modules being turned on... should this be fixed there instead?

#4

Exactly. This is the one profile in the drupal universe that doesn't add another module. With such an easy workaround, I really don't see the value in hunting for a deeper change.

#5

Thanks Moshe!
This fixes the problem I was speaking to you about at the Drupalcon CPH sprint, before I had to rush off.

#6

Mmm. This smells an awful lot like #898654: Required modules not installed before optional modules to me. I'd prefer to fix this at the source.

#7

Status:needs review» closed (duplicate)

Yup. That patch fixes this issue. Just confirmed it.

nobody click here