Hi beautiful Drupal.org webmaster team.

At the Core Developer Summit in Copenhagen, webchick gave a talk on the CVS application process which states that it is in rough shape. We did make some decision about the git migration and contribution application process, but it will still involve reviewing code.

I lead a BoF on the review process and we started a handbook page: How to review. I am still working on filling that out, but should be done soon.

In conjunction with the new handbook page, and hopefully revived interest in reviewing contribution apps, I was hoping to add a "I reviewed Drupal code contribution applications" option for peoples profile, similar to "I contributed Drupal automated tests". This is not a huge deal, but I thought I would put it out there.

Thank you.

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

How to review seems quite redundant with the already existing book pages, so far. As the pages are part of the same book, what is the purpose of the new book page?

The field should be titled I reviewed CVS applications, or I reviewed code applications, IMO.

zzolo’s picture

zzolo commented

Hi @kiam. I was going to have you look at this when it was more complete. The idea is to provide a single page for reviewers so that it is very minimal for people to review applications accurately. Currently, the documentation is there, but the audience is for the applicant, not the reviewer. Also, the benefit of being able to link to a single page is huge as far as the barrier to getting people to help out to review.

I am not that concerned with the wording.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Currently, the documentation is there, but the audience is for the applicant, not the reviewer.

CVS applications review, what to expect is for who applies, and who reviews the applications. Having separated pages requires to synchronize the content of two different pages when one of them is changed.

zzolo’s picture

zzolo commented

The audience of that page is very clearly the applicant, IMO, as all the points are a similar perspective as "Your module shows no hint of Coding Standards.", though I do agree it does serve as information for both audiences. Also, my new page does not aim to duplicate that information, but instead create a more higher level overview and complete picture of the review process.

Either way, though I don't agree, I would be happy to put this information into that article.

Also, that page is not the focus of this issue. I am very eager to discuss the content of that handbook page via IRC or another issue, as this was my intention originally after I had filled it in more.

sreynen’s picture

sreynen commented

I like the "I reviewed Drupal code contribution applications" language, but that doesn't really match the language elsewhere. It's almost universally referred to as "CVS applications," so until that's changed, I think the checkbox label would be most clear using the same language.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

'I help mentor new code contributors' ?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

To mentor is different from reviewing code. I would use to review, which has a more generic meaning.

zzolo’s picture

zzolo commented

Ok, so I would love to push this through, but I have no power to do so. Is there anything I can help with this?

I would suggest this for now, and it can easily be changed later if necessary and still hold the same value:
I reviewed CVS applications

Please note that I have pretty much finished this article, if anyone is interested in giving feedback or editing directly: How to review

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno

I suppose that other webmasters should chime in, and say if they are favorable to add this field in the user profile.

I am favorable, and I would use I reviewed CVS applications, which can be changed when CVS will not be anymore used on Drupal.org, or when GIT will be used too.
If there is nobody that is against adding this field in the user profile, I will add it tomorrow.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.