DatabaseSchema_sqlite::findTables() shouldn't find indexes [#897650]

After #851168: db_find_tables() expects tables to be prefixed, inconsistent implementation and documentation, DatabaseSchema_sqlite::findTables() needs to be modified to support schemas (ie. the schema.table form for a table expression).

This is a requirement for #850852: Fix transaction failure and allow concurrent testing on SQLite.

Comment	File	Size	Author
#4	897650-limit-findtables-query-typo.patch	1.02 KB	Garrett Albright
#3	897650-limit-findtables-query.patch	1.02 KB	Garrett Albright
#1	897650-sqlite-find-table-schema.patch	874 bytes	damien tournoud

Comments

Comment #1

damien tournoud commented 30 August 2010 at 17:22

Status:

Active

» Needs review

Status	File	Size
new	897650-sqlite-find-table-schema.patch	874 bytes

Comment #2

30 August 2010 at 17:40

Status:

Needs review

» Needs work

The last submitted patch, 897650-sqlite-find-table-schema.patch, failed testing.

Comment #3

Garrett Albright commented 24 May 2011 at 13:52

Title:	DatabaseSchema_sqlite::findTables() doesn't support schemas	» DatabaseSchema_sqlite::findTables() shouldn't find indexes
Status:	Needs work	» Needs review

Status	File	Size
new	897650-limit-findtables-query.patch	1.02 KB

It appears that the meat of this issue, that of supporting a schema prefix, has been fixed elsewhere. However, another part of the patch, that of limiting the query to only finding tables, still needs to be put into place, because otherwise, it may return indexes:

sqlite> SELECT name, type FROM sqlite_master limit 10;
variable|table
sqlite_autoindex_variable_1|index
actions|table
sqlite_autoindex_actions_1|index
batch|table
batch_token|index
blocked_ips|table
sqlite_sequence|table
blocked_ips_blocked_ip|index
cache|table

Reroll which addresses this, as well as clarifies a comment.