OpenID login link can hide the wrong fields

We should be able to fix this by adding the form ids to the selector.

There are other conflicts, e.g. #edit-name. Here is what I came up with (I did not know that somebody was already working on this).

Maybe you could also fix the nearby weird indentation (3 spaces instead of 2)?

Otherwise it looks good to me. I noticed you changed $('div.messages.error').css('display', 'block'); to $('div.messages.error').hide(); which I guess is fine, no need to show error messages after these links are clicked.

By the way, while testing the contact page I noticed that the contact edit-name input gets the error class when login fails, and likewise login edit-name input gets error class when contact name is left blank. This looks like a regression in form API with error being set for all forms on the page, I will file an issue on that if I don't find one that already exists.

This fixes the weird 3 indentation too.

Reroll due to #22336: Move all core Drupal files under a /core folder to improve usability and upgrades.

+++ b/core/modules/openid/openid.js
@@ -2,17 +2,21 @@
   attach: function (context) {

Overall, it looks like we're missing a $.once() here...? (as in all other Drupal behaviors - otherwise, this behavior is executed multiple times when behaviors are re-run on the existing page)

+++ b/core/modules/openid/openid.js
@@ -2,17 +2,21 @@
+    // Match the forms user-login and user-login-form (the latter is defined in
+    // user_login_block()).
+    var form = $('#user-login, #user-login-form');

1) It would make much more sense to me if openid.module would apply a .openid-form CSS class to the forms it enhances. Based on that, this behavior would be way more robust:

$('form.openid-form', context).once('openid', function () {
});

+++ b/core/modules/openid/openid.js
@@ -36,12 +40,12 @@ Drupal.behaviors.openid = {
       .click(function () {
          openidElements.hide();
          loginElements.css('display', 'block');
...
+         // Clear OpenID Identifier field and remove possible error message.
+         openidIdentifier.val('').removeClass('error');
+         $('div.messages.error').hide();
+         // Set focus on username field.
+         form.find('input[name="name"]')[0].focus();
+         return false;
       });

This looks like a typical detach behavior method to me.

9 days to next Drupal core point release.

Thank you for good review comments.

Overall, it looks like we're missing a $.once() here...?

Similar logic is implemented via .openid-processed. I have updated it to use once() instead.

It would make much more sense to me if openid.module would apply a .openid-form CSS class to the forms it enhances.

Good point. Done.

This looks like a typical detach behavior method to me.

I'm not sure what you mean. Something like this?

-        $('div.messages.error').hide();
+        var error = $('div.messages.error');
+        if (error.size()) {
+          Drupal.detachBehaviors(error.get(0));
+          error.remove();
+        }

It'd be nice to agree on a common solution here, as #1395612: Conflict with core contact form in the CAS module is waiting on the outcome of this issue.

A fix for this issue is included in the patch for #1538462: Cannot log in with OpenID due to "required" attribute.

Fixed together with #1538462.