View does not refresh when it is embedded inside another view

Hi yaz085.

You are right in that this module isn't necessary when you use the "Normal link" widget to display the flag link. This module is specifically designed to bridge the Views and Flag projects when both of their their internal AJAX settings are enabled. With that being said, you have to make sure the view is configured to refresh when certain flags are selected. See the configuration section along with the image on this module's project page explaining how to configure the view to work with this module.

Can you confirm that the View is configured correctly? If so, let's continue this thread as a bug report and try to find out what the issue is.

Thanks for posting,
Chris

I can confirm the same problem. I'm using 6.x-2.11 and Views Flag Refresh 6.x-1.0-beta2

It seems that Views Flag Refresh does nothing.

Attached is a shot of my configuration.

Hi tomdisher.

Thanks for posting. Your configuration looks correct, and things should be working. Unfortunately I cannot replicate the issue, so it would be great if someone could help with the debugging. Couple of things I am interested in knowing...

• Does the module work with a default Drupal theme?
• Is there any custom theming that might be stripping out the default IDs and CSS classes set by the Views module?
• Are there any other modules, custom or contrib, that could be clashing with this module's JavaScript?
• Using Firebug or some other diagnostic tool, are there any JavaScript errors being thrown?
• Which browser(s) are you testing on?
• What version of the Flag module is being used?

Any information would be helpful in tracking this down.

Thanks,
Chris

Thanks for the quick reply, Chris.

It does look like it is working with the Garland theme. Any suggestions?

Further info:

-No JS errors

-I can't think of anything stripping the views classes and IDs

-Testing on Firefox 3.6.8

-Flag 6.x-1.3

Hi tomdisher.

Great information. I feel like we are getting closer. From what you said, it seems to be something isolated to the theme. Is this a custom theme or contributed theme? If custom, are you using a base theme? Also, are there any views / block templates in the theme?

Random thought, does your page.tpl.php have a <?php print $closure; ?>? Sometimes omitting that messes up javascript functionality.

Thanks again for the information,
Chris

Changing to a support request since the module works with a default Drupal theme. Will continue to help debug and will change back to a bug report if other information is uncovered.

Hi Chris

Thanks for your support- What actually happened:

I changed the default view settings which did not carry over to the block view for some reason. On one page I inserted the default - on another I inserted the block. The block was not working. When I checked with the garland theme I actually looked at the one calling the default values.

In short, it was an ID-10-T error.

I'm not sure why the default values were not overwritten in the block view. The block was set to use default values. That might be worth looking into.

Thanks again!

Tom

Haha! Thanks for posting back. I have been known to do that from time to time as well :-). Marking this thread as "fixed", and this will remain as a good debug tutorial for others who can't get the module to work.

Thanks for the posts,
Chris

Hi yaz085.

Thanks for all the info, very helpful. I actually haven't done anything with either Panels or with Views 3, so I will need to test integration with both of those modules. My guess is there is some API change in Views 3 that prevents this module from working, but I will also test any quirks with Panels. Changing back to a bug report.

Thanks,
Chris

yaz085,

Just to report back, I tested with both Panels and Views 3 and they work using standard templates. Taking another look at your post, views_embed_view() should work fine, but the fact that they are injected into the template of another view may be causing an issue. Would you feel comfortable either sharing the template file referenced in #11 or pointing me to a public facing site where these views are being rendered?

Thanks,
Chris

Hello,

I'm trying out this cool module and experiencing this same issue.
I'm also using views_embed_view.

I checked out the attachment in #14 and my setup is the same.

Regards

Thanks for the input yaz085 and trupal218.

yaz085, I was able to rebuild your setup and I confirmed what you are seeing. First, views_embed_view() works fine by itself. The issue is when it is used inside another view. This is definitely an edge case, but I will investigate if it can be resolved. I am also changing the title to reflect the diagnosis of the bug.

Also if I could weigh in from a best practices standpoint, generally setups like this use the Views "Attachment" display to chain multiple views together instead of putting this logic in a template. I tested the setup using attachment displays instead of placing views_embed_view() directly inside the template, and the refresh worked for all views as expected. As a side note, calling the function in the template also breaks the flag JavaScript widget if an exposed filter is submitted. The Flag bug does not appear when using Attachments.

My feeling is that we are really wrestling with Views at this point, and Views Flag Refresh appears to work when the normal channels available to the module are used. The addition of the Flag bug also makes me think this setup may cause other problems beyond the one reported in this issue, so I am bumping the priority to "minor". I would be curious to get your feedback on this.

Thanks again for posting the code. Extremely helpful in determining the root cause of this bug.
~Chris

Hi yaz085.

Thanks for posting back. Completely understood with complex layouts. I will refocus my efforts to get this module working in the setup you outlined. There has to be a way to do this.

Thanks again,
Chris

I think using panels instead of views attachments or embeds is a better approach, if possible. I'm noticing something similar with panels. When I have to flag / draggable enabled views in one panel page, say one on top of each other. When I click a flag, both views refresh the first time, which is good. But then, the page is kind of broken after that. I can tell the css is a bit broken cause the link colors revert back to the base theme. Is there a reason why two views using flag refresh could not be on the same page, responding to the same flag event? It works the first time perfectly, but just can't handle subsequent flag events after that, without a complete page refresh.

The use case is sort of common. Have a queue of nodes that all have a flag set in the middle panel. Then have a list of "potential nodes" in a panel on the right with flag links. You click a flag link, the node gets added to the queue. It works great the first time.

Thanks for any help.

I'm actually experiencing the same thing, the view works great the first time I flag (I'm using one view for a node's comments and another small view in a viewfield), but refreshing doesn't work after that.

After that first, successful time something is flagged and refreshed, if I looked at the status bar of the browser it looked like it made an extra request without anything happening on the page after it ended. So I checked the console and this error was shown twice consecutively:

The stylesheet http://site.com/ was not loaded because its MIME type, "text/html", is not "text/css".

Then I checked the net tab, and after the first flag link posts these all return 200:

http://site.com/views/ajax?view_name=the_view_name_1&view_display_id=default&view_args=43&view_path=node%2F43&view_base_path=node%2F43&view_dom_id=1&pager_element=0

http://site.com/views/ajax?view_name=the_view_name_1&view_display_id=default&view_args=43&view_path=node%2F43&view_base_path=node%2F43&view_dom_id=2&pager_element=0

http://site.com/views/ajax?view_name=the_view_name_2&view_display_id=default&view_args=43%2F&view_path=node%2F43&view_base_path=null&view_dom_id=3&pager_element=1

Then there's two GET requests to two zen theme stylesheets (style and zen.css) that get returned 301. This, I am sure, is because I am using a custom sub theme through zen, and did a poor job of commenting out all of the parent theme stylesheet calls. But it explains what the previous poster described. Then two consecutive GET requests to http://site.com that returned 200.

Then after the second flag is clicked (and after that link's POST request) this returned 200:

http://site.com/views/ajax?view_name=view_name_1&view_display_id=default&view_args=43&view_path=node%2F43&view_base_path=null&view_dom_id=2&pager_element=0

Problem is identical in Garland theme too (so just disregard the part in my previous post about the the two stylesheets that returned a 301).

Also, I noticed a something interesting about the bug:

• When 1st flagging in "view_1" -> "view_1" & "view_2" are refreshed.
• When 2nd flagging in "view_1" -> "view_2" is refreshed.
• When 3rd flagging in "view_1" -> "view_2" is refreshed and so on...
(it's the same deal vice-versa too.)

I plan on staring at the code for a while and hoping I find a clue on where to start trying to fix it, so if anyone has a tip on what part of the code this should involve, please post.

I'm having the same problem. Has anyone had any further progress?

Unfortunately I cannot replicate the issue, and due to #D7CX commitments I don't have much free time to spend this at the current moment. Would love to see some patches from developers who are experience this issue, and would be willing to take on a co-maintainer once someone submits a few patches.

Sorry for the delays,
Chris