Seems to work nicely - except that it changes the user's existing setting of an exposed flag filter. E.g., if exposed filter is set to false, and the "change favorite flag to true" is clicked, the module correctly removes that item, but the filter is set to true (and the resulting view reflects that new setting) even though the user wanted to continue seeing non-favorites. So, if this is intended, my feature request would be to allow existing exposed filter settings to be preserved. Thanks very much for the module.

CommentFileSizeAuthor
#3 views_flag_refresh-898434-3.patch3.62 KBcpliakas
#2 views_flag_refresh-898434-2.patch3.72 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented
Title: Changes exposed flag filter setting » Exposed filters are lost when view is refreshed
Component: Miscellaneous » Code
Assigned: Unassigned » cpliakas
Category: feature » bug
Issue tags: +6.x-1.0-beta2

RJL,

You beat me to it :-). I released the module with this being a "known" issue, but you have a great eye for detail and posted before I could. Thanks for testing, and this is targeted for being fixed in the next release. Changing to a bug report, and modifying the title a bit.

Thanks for posting,
Chris

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new views_flag_refresh-898434-2.patch3.72 KB

Here is my first crack at a solution that seems to work on my dev machine. Javascript can be cleaned up some, but would appreciate input as to whether or not this solves the issue.

Thanks,
Chris

cpliakas’s picture

cpliakas commented
StatusFileSize
new views_flag_refresh-898434-3.patch3.62 KB

Same functionality, JS has been cleaned up to remove duplicate code.

cpliakas’s picture

cpliakas commented
Status: Needs review » Fixed

Tested this in a few places, and it seems to work. Committed at #415076.

RJL-dupe’s picture

RJL-dupe commented

If I download the latest version from the drupal project site, will that be the correct version to test? Thanks for your quick follow-up on this.

RJL-dupe’s picture

RJL-dupe commented
cpliakas’s picture

cpliakas commented

Hi RJL.

The fix will be reflected in the beta2 release which isn't on D.O. yet. Hopefully I will release it tonight. In order to test, you have to download the patch in #3 and apply it to the current version of the module you are using. Instructions for applying patches are located at http://drupal.org/node/60108.

Thanks for the interest,
Chris

cpliakas’s picture

cpliakas commented

Quick update, beta2 has been released which has the patch rolled in.

RJL-dupe’s picture

RJL-dupe commented

Fantastic! Thanks so much - it's working perfectly for me now, and is making a huge difference. I'm new at Drupal, and don't know whether I or the maintainer changes this to "fixed", so I'll leave it at its current status. Again, thanks very much for a really nice module and your willingness to respond to issues.

cpliakas’s picture

cpliakas commented

Welcome to Drupal, RJL! Technically anyone can change the status, but generally the maintainer has the last say. In this case, your confirmation that things are working is all that is needed.

Thanks again for the early adoption and testing of the module,
Chris

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tiw’s picture

tiw commented

I am using the latest version, but am facing this issue.

When I click 'submit' in my exposed filter block, the result set is working correctly. But when I refresh a flag on the page, I lose the chosen exposed filters and the result set is updated to include all the items.

Any suggestions?

tiw’s picture

tiw commented
Status: Closed (fixed) » Active

Can someone help with this?

In my product selector page, I have an exposed filter block EB1 (which has the exposed filters), a content pane CP1 which displays products based on the filters selected and another content pane CP2 (from a different view) which displays only the flagged products. CP1 and CP2 have flag links that enable product to be either selected or not selected.

User can flag products (using a link) in CP1 and that would get automatically reflected in CP2. This works fine. However, when the user unflags the product in CP2, it doesn't get reflected in CP1. The only way to make this happen is if I choose 'refresh display on flag' setting in CP1. However, if I do that, I lose all the filter settings and the CP1 displays all the products instead of products that qualify according to the parameters chosen in the filters.

In short, I need to have 1) the content pane CP1 display only the products that qualify by the filters in exposed block EB1, and 2) unflagging the products in content pane CP2 should update CP1 accordingly. It seems like I can get one thing to work at a time, but not both.

Thanks for your help.