Hi,
I installed Custom Breadcrumbs and it is working great.
I see my panels term-page is deactivated, and have it working again using, http://drupal.org/node/857484.

But now the current term is not shown on the breadcrumb, and if I activate panels, after the breadcrumb, there is stated the headterm again.
For example taxonomy page without panels (disable term-page override):

Home > Italy > Toscane > Florence

After enabling term-page override:

Home > Italy > Toscane

Or using Custom Breadcrumb Panels

Home > Italy > Toscane > Italy

Sorry to have to report this.

Thanks for going into this!
Greetings,
Martijn

CommentFileSizeAuthor
#1 898750_taxonomy_panel_override.diff1.12 KBMGN

Comments

MGN’s picture

MGN commented
Status: Active » Needs review
StatusFileSize
new 898750_taxonomy_panel_override.diff1.12 KB

Thanks for the report. I think I understand what is happening now. The taxonomy/term/%term override isn't working as it is written in custom_breadcrumbs_panels. The hook into ctools_context_handler_render works only if the panel has a handler, and apparently the taxonomy template doesn't. The patch modifies custom_breadcrumbs_taxonomy so that it will try to work through the panels override. Previously I thought this would fail - perhaps it did in Panels 2? But with the latest code (and using Panels 6.x-3.5 - I know I need to upgrade!) it seems to work! More testing is definitely needed!

Also, before testing, check to see that "Inject hierarchy of first term into breadcrumb trail" is disabled for the taxonomy term template (under basic settings).

Rather than using panels to set the hierarchy, you can use custom breadcrumbs taxonomy. Enable the "Use the taxonomy hierarchy to set the breadcrumb trail for nodes and taxonomy pages" (and any other taxonomy options you like) on the custom breadcrumbs configuration page.

That should do it.

summit’s picture

summit commented

Hi,
I do not get the:

check to see that "Inject hierarchy of first term into breadcrumb trail" is disabled for the taxonomy term template (under basic settings).

Do you mean under /admin/settings/custom-breadcrumbs? I installed latest 6.x-2.x-dev (oct-07).
I do not see that option anywhere under /admin/settings/custom-breadcrumbs?

greetings,
Martijn

summit’s picture

summit commented

Aha, found it under admin/build/pages/edit/term_view. It was enabled. Will review further.
Hi, I think with this patch and disabling panel term_view inject, this stuff is working!
greetings, Martijn

summit’s picture

summit commented
Status: Needs review » Fixed

Hi Michael,
It is working great! Thanks.

greetings, Martijn

MGN’s picture

MGN commented

Thanks for testing!

MGN’s picture

MGN commented

This fix has now been committed to 6.x-2.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.