Closed (fixed)
Project:
Atlassian Crowd SSO
Version:
6.x-1.0
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
31 Aug 2010 at 21:43 UTC
Updated:
16 Sep 2010 at 00:50 UTC
Line 497 of crowd.module:
if(CROWD_USELDAP) {
require_once(drupal_get_path('module', 'ldapgroups') .'/ldapgroups.inc');
It seems as though the constant here is true even though I've never installed any ldap modules.
Comments
Comment #1
ebeyrent commentedInteresting.
The constant is defined in crowd.module:
and this variable is controlled in the Crowd admin settings (admin/settings/crowd). If the LDAP Auth module is enabled, you get a bunch of LDAP-specific options. That's the only way the variable gets set.
Can you please take a look at your variable table and let me know what the value of crowd_useldap is? Please also confirm that the ldap_auth module is not enabled.
Comment #2
dstolIt's not set. It's a completely fresh install, I don't have the ldapauth modules in drupal anywhere.
Because the module doesn't exist the constant is never set. So it seems as though PHP interprets it as a string which
Will return true because it's a string.
Try this in devel/php
It should return string.
I think the solution here is to take the constant setting out of the if (module_exists('ldapauth')).
The crowd related variables:
crowd_validate_token
crowd_uri
crowd_server
crowd_secure_sso_cookie
crowd_port
crowd_pages
crowd_logout_no_cookie
crowd_exclude
crowd_cookie_sso_domain
crowd_auto_assigned_role
crowd_application_password
crowd_application
crowd_access
Comment #3
ebeyrent commentedUgh. You're absolutely correct. I've committed this change. Please download the 6.x-1.1 release and let me know if you find any other issues.
Thanks!