CVS edit link for correodirect

I want to contrib with one third-party integration module and maintain it.

Comments

correodirect’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new11.62 KB
pcambra’s picture

Status: Needs review » Needs work

Thanks for your application for a CVS account.
Please, review the CVS application requirements here http://drupal.org/cvs-application/requirements

"You must provide a motivation message, which should be a few paragraphs instead of only a few sentences. It should include details about your contribution, its features, how it compares to already existing solutions, links to screenshots or a demo, etc."

correodirect’s picture

Ok, how can I edit the motivations?

pcambra’s picture

Hi
Just put a reply in this post with them.

correodirect’s picture

StatusFileSize
new12.14 KB

Description:
Joins our Drupal site to Correo Direct (permission marketing platform) affiliate program and integrate the co-register form on Drupal new user register page. Correo Direct helps webmasters to make money with users registrations.

correodirect’s picture

Status: Needs work » Needs review

Needs review.

avpaderno’s picture

A two sentences description is few. The requirements talk of few paragraphs; even in the case few paragraphs are too much, two sentences are still few.

pcambra’s picture

Status: Needs review » Needs work
correodirect’s picture

Status: Needs work » Needs review

Description:
Joins our Drupal site to Correo Direct (permission marketing platform) affiliate program and integrate the co-register form on Drupal new user register page. Correo Direct helps webmasters to make money with users registrations.
The module alows webmasters to signup on affiliate program from the module administration and shows a CorreoDirect coregistration zone for new users registration.
After the webmaster is an affiliate he receives by email login and password for his affiliate control panel in CorreoDirect (Stats and revenue).

Admin affiliate signup screenshot:
http://img828.imageshack.us/img828/719/mozscreenshot1.png

User co-registration online demo:
http://test.fernandodelpozo.com/drupal6/user/register

About Correo Direct: https://secure.correodirect.com/public/compromiso.php

pcambra’s picture

Status: Needs review » Needs work

Hi

Here are some points I've found doing a review of the code, they aren't sorted by importance:

  • .info file: You shouldn't include version info as drupal package system does that for you, neither the folder should have the version in the name, take a look to the info guidelines http://drupal.org/node/231036 package information would be good as well
  • Please include a README.txt file (in English) of what the module does and a English version of INSTALL.txt
  • .install file: A header comment block should be included just after the php init tag, guidelines: http://drupal.org/node/546
  • .module file: A header comment block should be included just after the php init tag, guidelines: http://drupal.org/node/546
  • .module file: All comments should be in English and all the literals have to be originally in English as well, and invoked through a t() call, revise this documentation for more info: http://drupal.org/node/539608
  • .module file: Please revise indents and coding standards, see http://drupal.org/coding-standards and run your code through coder module and it will check most of these issues for you http://drupal.org/project/coder
  • .module file: You should comment each function using Doxygen http://drupal.org/node/1354
  • .module file: I see there is a terms of service agreement inside the module, I'm not really sure that the text belongs there, bear in mind that .module file is loaded *constantly* and you don't want to carry that in all calls, you can take the admin menu to a admin.inc file in hook_menu invocation and take the settings to a separate file. Also, all texts should be translatable and originally in English.
avpaderno’s picture

Status: Needs work » Closed (won't fix)